refactor(obstacle_cruise): refactor a function checkConsistency() #7105
CodeScene PR Check
✅ Code Health Quality Gates: OK
- Improving Code Health: 4 findings(s) ✅
Details
✅ Improving Code Health:
- Lines of Code in a Single File node.cpp
- Overall Code Complexity node.cpp
- Complex Method node.cpp: ObstacleCruisePlannerNode::checkConsistency
- Bumpy Road Ahead node.cpp: ObstacleCruisePlannerNode::checkConsistency
Annotations
Check notice on line 1 in planning/obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Lines of Code in a Single File
The lines of code decreases from 1252 to 1240, improve code health by reducing it to 1000. The number of Lines of Code in a single file. More Lines of Code lowers the code health.
Check notice on line 1420 in planning/obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ No longer an issue: Complex Method
ObstacleCruisePlannerNode::checkConsistency is no longer above the threshold for cyclomatic complexity. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
Check notice on line 1420 in planning/obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Bumpy Road Ahead
ObstacleCruisePlannerNode::checkConsistency decreases from 3 to 2 logical blocks with deeply nested code, threshold is one single block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
Check notice on line 1 in planning/obstacle_cruise_planner/src/node.cpp
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
✅ Getting better: Overall Code Complexity
The mean cyclomatic complexity decreases from 4.42 to 4.37, threshold = 4. This file has many conditional statements (e.g. if, for, while) across its implementation, leading to lower code health. Avoid adding more conditionals.