-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(ad_service_state_monitor): modify build error in rolling #716
fix(ad_service_state_monitor): modify build error in rolling #716
Conversation
Codecov Report
@@ Coverage Diff @@
## main #716 +/- ##
========================================
- Coverage 9.63% 9.60% -0.04%
========================================
Files 907 907
Lines 56520 56746 +226
Branches 6694 6694
========================================
Hits 5448 5448
- Misses 46577 46803 +226
Partials 4495 4495
*This pull request uses carry forward flags. Click here to find out more.
Continue to review full report at Codecov.
|
@@ -29,6 +29,11 @@ ament_auto_add_executable(ad_service_state_monitor | |||
${AD_SERVICE_STATE_MONITOR_SRC} | |||
) | |||
|
|||
# workaround to allow deprecated header to build on both galactic and rolling | |||
target_compile_options(ad_service_state_monitor PRIVATE |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please apply the same solution as in #720 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: wep21 <[email protected]>
* Feature/porting control performance analysis (autowarefoundation#1671) * Feature/control performance analysis (autowarefoundation#1212) * First commit of kinematic_controller * First commit. * second commit * Just setup updated Autoware. * changed package name. * Messages variables are created. * Writing subscribers and publishers. * Writing subscribers. Traj, pose and control_values are read into the node. * Computing control performance variables. * Computing control performance variables. * Current velocity subscribed. * Acceleration performance is computed. * Publishing completed. Will start rqt_multiplot * Publishing completed. Decay rate fixed. Will start rqt_multiplot * rqt_multiplot first configuration. * Update pure_pursuit.launch * Update pure_pursuit.launch * Update .gitignore * Update Error.msg * Update control_performance_utils.cpp * Update ErrorStamped.msg * Update package.xml * rqt_multiplot first configuration. * Update controller_performance_core.cpp * Update controller_performance_core.cpp * Update CMakeLists.txt * Update control_performance_analysis_param.yaml * EPS is added for value_decay_rate. * There is a bug. * Bug removed. * Bug removed. * lateral_acceleration is published. * Interpolated pose is added. * Update controller_performance_node.cpp * find Curve index bug is removed. * dot product on projection is updated. * Vehicle measured steering is included in the node and rqt_graph. * Review will be requested. * After the test: Three point curvature module is added. Std:vector will be fixed. * After the test: Curvature plot is added. * After the test: Fine tuned. * rqt curvature is modified. * Pure pursuit curvature is implemented and tested. Results are fine. * addressed some code review issues. Will replace get_pose. * GetPose is removed. * All the core review issues have been addressed. * Rename files Signed-off-by: wep21 <[email protected]> * Porting control performance analysis Signed-off-by: wep21 <[email protected]> * Apply lint Signed-off-by: wep21 <[email protected]> * Add boost dependency for optional Signed-off-by: wep21 <[email protected]> * Remove confusing abbreviation Signed-off-by: wep21 <[email protected]> * Fix dependency in packages.xml Signed-off-by: wep21 <[email protected]> * Add missing new line Signed-off-by: wep21 <[email protected]> * Add comment for eigen macro Signed-off-by: wep21 <[email protected]> * pre-commit fixes Signed-off-by: wep21 <[email protected]> Co-authored-by: Ali BOYALI <[email protected]> * Fix package.xml (autowarefoundation#2056) Signed-off-by: Kenji Miyake <[email protected]> * Fix typo for control_performance_analysis (autowarefoundation#2328) * fix typo * fix Contro -> Control * fix for spellcheck * fix * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> * adapt to actuation cmd/status as control msg (autowarefoundation#646) * adapt to actuation cmd/status as control msg * fix readme * fix topics * fix remaing topics * as to pacmod interface * fix vehicle status * add header to twist * revert gyro_odometer_change * revert twist topic change * revert unchanged package * port control_performance_analysis (autowarefoundation#698) * port control_performance_analysis Signed-off-by: kosuke murakami <[email protected]> * rename Signed-off-by: kosuke murakami <[email protected]> * fix topic name Signed-off-by: kosuke murakami <[email protected]> * remove unnecessary depedency Signed-off-by: kosuke murakami <[email protected]> * change name of odom topic Signed-off-by: kosuke murakami <[email protected]> * add readme in control_performance_analysis (autowarefoundation#716) * add readme Signed-off-by: kosuke murakami <[email protected]> * update readme * update readme * Update control/control_performance_analysis/README.md * Update twist topic name (autowarefoundation#736) Signed-off-by: wep21 <[email protected]> * Apply suggestions from code review Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Ali BOYALI <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Kosuke Murakami <[email protected]> Co-authored-by: Tomoya Kimura <[email protected]>
#define FMT_HEADER_ONLY | ||
#include "ad_service_state_monitor/state_machine.hpp" | ||
|
||
#define FMT_HEADER_ONLY // NOLINT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just out of curiosity, what's this NOLINT
for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kenji-miyake pre-commit fixes include order as below.
#define FMT_HEADER_ONLY
#include "ad_service_state_monitor/state_machine.hpp"
#include <fmt/format.h>
I felt this order is a little bit weird, so I added NOLINT
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see, but I think it's okay to define all macros at the top of headers.
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
Signed-off-by: wep21 <[email protected]>
chore(intersection): publish decision status string (autowarefoundation#4456)
Description
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.