Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_auto_geometry): modify build error in rolling #719

Closed
wants to merge 1 commit into from
Closed

fix(autoware_auto_geometry): modify build error in rolling #719

wants to merge 1 commit into from

Conversation

wep21
Copy link
Contributor

@wep21 wep21 commented Apr 17, 2022

Description

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@wep21 wep21 requested a review from kenji-miyake April 17, 2022 19:39
@wep21 wep21 added ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release. labels Apr 17, 2022
@codecov
Copy link

codecov bot commented Apr 18, 2022

Codecov Report

Merging #719 (db08163) into main (3bca407) will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff          @@
##            main    #719   +/-   ##
=====================================
  Coverage   9.63%   9.63%           
=====================================
  Files        907     907           
  Lines      56441   56441           
  Branches    6681    6681           
=====================================
  Hits        5439    5439           
  Misses     46519   46519           
  Partials    4483    4483
Flag Coverage Δ *Carryforward flag
differential 50.31% <ø> (?)
total 9.63% <ø> (ø) Carriedforward from 3bca407

*This pull request uses carry forward flags. Click here to find out more.

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 155eda4...db08163. Read the comment docs.

esteve
esteve requested changes Apr 18, 2022
View reviewed changes
Copy link
Contributor

@esteve esteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same solution as in #720 (comment)

esteve
esteve requested changes Apr 18, 2022
View reviewed changes
common/autoware_auto_geometry/CMakeLists.txt
@@ -30,6 +30,10 @@ ament_auto_add_library(${PROJECT_NAME} SHARED
src/spatial_hash.cpp
src/bounding_box.cpp)
autoware_set_compile_options(${PROJECT_NAME})
# workaround to allow deprecated header to build on both galactic and rolling
target_compile_options(${PROJECT_NAME} PUBLIC
-Wno-error
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please apply the same solution as in #720 (comment)

@wep21 wep21 closed this Apr 21, 2022
isamu-takagi added a commit to isamu-takagi/autoware.universe that referenced this pull request Apr 21, 2022
@1222-takeshi @mitsudome-r
@YamatoAndo @yukkysaito @harihitode @kenji-miyake @nnmm @TakaHoribe @fred-apex-ai @jilaada @k0suke-murakami @wep21 @taikitanaka3 @RyuYamamoto @kmiya @ito-san @tkimura4 @s-azumi @KeisukeShima @0x126 @rej55 @h-ohta @kosuke55 @IshitaTakeshi @miursh @maxime-clem @drwnz @satoshi-ota @takayuki5168 @tier4-autoware-private-bot @mkuri @purewater0901 @isamu-takagi @kyoichi-sugahara @s-murakami-esol @yukke42 @aohsato
feat: add pointcloud packages (autowarefoundation#39)
fe1195e 
* release v0.4.0

* add convertToXYZCloud (#706)

* Fix/concat mutex bug (#711)

* modify defautl value

Signed-off-by: Yamato Ando <[email protected]>

* fix bug

Signed-off-by: Yamato Ando <[email protected]>

* fix mutex bug

Signed-off-by: Yamato Ando <[email protected]>

* bug fix and reduce calc cost (#708)

* bug fix and reduce calc cost

Signed-off-by: Yukihiro Saito <[email protected]>

* fixed bug

Signed-off-by: Yukihiro Saito <[email protected]>

* Revert "bug fix and reduce calc cost (#708)" (#719)

This reverts commit e69564a4071a0849435ac8ffe54fe4e49d8e3974.

* Avoid setting CMAKE_BUILD_TYPE=Release in each CMakeLists.txt (#720)

* remove set CMAKE_BUILD_TYPE Release in each CMakeLists.txt

* remove set CMAKE_BUILD_TYPE Release in ndt_pcl_modified

* set compile options for debug in ndt_omp

* Fix indent

* add warning if -DCMAKE_BUILD_TYPE=Release is not set in ndt_omp

Co-authored-by: Kenji Miyake <[email protected]>

* ring_outlier_filter: fix bug, and check azimuth (#727)

* fix bug, and check azimuth

Signed-off-by: Yamato Ando <[email protected]>

* reduce calc cost

Signed-off-by: Yukihiro Saito <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* Fix/ring outlier filter bug (#762)

* fix bug, and check azimuth

Signed-off-by: Yamato Ando <[email protected]>

* reduce calc cost

Signed-off-by: Yukihiro Saito <[email protected]>

* fix bug

Signed-off-by: Yukihiro Saito <[email protected]>

* change default param

Signed-off-by: Yukihiro Saito <[email protected]>

Co-authored-by: Yamato Ando <[email protected]>

* remove ROS1 packages temporarily

Signed-off-by: mitsudome-r <[email protected]>

* Revert "remove ROS1 packages temporarily"

This reverts commit bcab06f1790bbe6d2441ad18a6430fde31ca483e.

Signed-off-by: mitsudome-r <[email protected]>

* add COLCON_IGNORE to ros1 packages

Signed-off-by: mitsudome-r <[email protected]>

* Rename launch files to launch.xml (#28)

* Port points preprocessor (#114)

* Add pcl_component.h.
 - originally from Willow Garage.
 - Ported to ROS2 component class by SImon Thompson.

Signed-off-by: Takamasa Horibe <[email protected]>

* Port CMakelists & package.xml & concatenate_data
 - timer frequency handing is not ported (the logic is changed)
 - remove dependency and functions of NodeletLazy

Signed-off-by: Takamasa Horibe <[email protected]>

* move required functions from pcl_component.h to filter.h, port rayground_filter

Signed-off-by: Takamasa Horibe <[email protected]>

* add crop box filter

Signed-off-by: Takamasa Horibe <[email protected]>

* arrange make order

Signed-off-by: Takamasa Horibe <[email protected]>

* port voxel grid downsample filter

Signed-off-by: Takamasa Horibe <[email protected]>

* port pointcloud accumulator

Signed-off-by: Takamasa Horibe <[email protected]>

* port compare map filters

Signed-off-by: Takamasa Horibe <[email protected]>

* port outlier filters

Signed-off-by: Takamasa Horibe <[email protected]>

* port passthrough filters

Signed-off-by: Takamasa Horibe <[email protected]>

* fix pcl deprecates:
 - replace pcl::uint16_t -> std::uint16_t
 - replace pcl_isfinite  -> std::isfinite
 - replace pcl::getFieldIndex(input, name, fields) -> pcl::getFieldIndex<PointT>(name, fields)

Signed-off-by: Takamasa Horibe <[email protected]>

* add parameter service callback (port dynamic reconfigure)

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused file

Signed-off-by: Takamasa Horibe <[email protected]>

* fix: add missing return

Signed-off-by: Takamasa Horibe <[email protected]>

* add input/output_frame parameter service callback in Filter class

Signed-off-by: Takamasa Horibe <[email protected]>

* message_filter : boost::shared_ptr -> std::shared_ptr

Signed-off-by: Takamasa Horibe <[email protected]>

* fix pcl::getPointCloudDifference deprecate

Signed-off-by: Takamasa Horibe <[email protected]>

* add License

Signed-off-by: Takamasa Horibe <[email protected]>

* fix cmake compile options

Signed-off-by: Takamasa Horibe <[email protected]>

* fix warning

Signed-off-by: Takamasa Horibe <[email protected]>

* move init & subscribe functions to constructor

Signed-off-by: Takamasa Horibe <[email protected]>

* port ring_passthrough_filter.launch.xml

Signed-off-by: Takamasa Horibe <[email protected]>

* fix component register plugin name

Signed-off-by: Takamasa Horibe <[email protected]>

* add default param, remove duplicated node name for debug print

Signed-off-by: Takamasa Horibe <[email protected]>

* add default value for concat_data args

Signed-off-by: Takamasa Horibe <[email protected]>

* add preprocessor.launch.py

Signed-off-by: Takamasa Horibe <[email protected]>

* remove old file

Signed-off-by: Takamasa Horibe <[email protected]>

* add ros parameter initialization

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused files

Signed-off-by: Takamasa Horibe <[email protected]>

* apply clang format

Signed-off-by: Takamasa Horibe <[email protected]>

* replace _exe to _node for executable

Signed-off-by: Takamasa Horibe <[email protected]>

* remove unused main.cpp

Signed-off-by: Takamasa Horibe <[email protected]>

* minor fix: change param name

Signed-off-by: Takamasa Horibe <[email protected]>

* add preprocessor.launch.xml launch (#123)

Signed-off-by: Takamasa Horibe <[email protected]>

* [pointcloud-preprocessor] Link missing opencv libraries (#133)

to fix linker error in downstream package

* Rename h files to hpp (#142)

* Change includes

* Rename files

* Adjustments to make things compile

* Other packages

* Adjust copyright notice on 532 out of 699 source files (#143)

* Use quotes for includes where appropriate (#144)

* Use quotes for includes where appropriate

* Fix lint tests

* Make tests pass hopefully

* Run uncrustify on the entire Pilot.Auto codebase (#151)

* Run uncrustify on the entire Pilot.Auto codebase

* Exclude open PRs

* ROS2 Linting: pointcloud_preprocessor (#180)

* Add linter tests

* Run cppcheck and fix errors

* Address PR Comments:
 - Remove the impl file and merge the two header files

* Remove colcon build warning for PCL libraries
 - #129 issue

* Address PR comment:
 - Reorder calls to find package and build dependencies to suppress build warnings

* [ray_ground_filter] overwrite frame_id of output_msg with base_frame_ (#216)

Signed-off-by: Autoware <[email protected]>

Co-authored-by: Autoware <[email protected]>

* fix tf (#232)

Signed-off-by: mitsudome-r <[email protected]>

* apply env_var to  use_sim_time (#222)

* Ros2 v0.8.0 pointcloud preprocessor (#293)

* fix height threshold bug (#1102) (#371)

Signed-off-by: mitsudome-r <[email protected]>

Co-authored-by: Taichi Higashide <[email protected]>

* Add livox_tag_filter (#368)

* Add livox_tag_filter (#1140)

* Add livox_tag_filter

Signed-off-by: Kenji Miyake <[email protected]>

* Remove dependency of livox_ros_driver

Signed-off-by: Kenji Miyake <[email protected]>

[livox_tag_filter] port to ROS2

Signed-off-by: mitsudome-r <[email protected]>

* fix test failures

Signed-off-by: mitsudome-r <[email protected]>

* Move livox_tag_filter under livox/ directory

Signed-off-by: mitsudome-r <[email protected]>

* address review comments

Signed-off-by: mitsudome-r <[email protected]>

* fix lint test error

Signed-off-by: mitsudome-r <[email protected]>

* make livox_tag_filter_node to component

Signed-off-by: mitsudome-r <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* Add tier4_pcl_extensions (#1162) (#377)

* Add tier4_pcl_extensions (#1162)

* Add tier4_pcl_extensions

Signed-off-by: Kenji Miyake <[email protected]>

* Move to sensing/preprocessor/pointcloud

Signed-off-by: Kenji Miyake <[email protected]>

port to ROS2

Signed-off-by: mitsudome-r <[email protected]>

* fix lint errors

Signed-off-by: mitsudome-r <[email protected]>

* fix include brackets

Signed-off-by: mitsudome-r <[email protected]>

* add dependency to pcl

Signed-off-by: mitsudome-r <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* Sync with Ros2 v0.8.0 beta (#393)

* add nullptr check when publish concatenate data (#369)

* Add warning msg when concat pointcloud is not published (#388)

Signed-off-by: Kenji Miyake <[email protected]>

* add timeout notification stamp msgs (#363)

* add timeout notification stamp msgs

* fix uncursify

* delete timeout notification stamped

* Revert "delete timeout notification stamped"

This reverts commit 365d29209f6a7f5ec75eb80c5d8c2ef38daeae79.

* fix message

Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>

* Add approximate voxel grid filter (#1144) (#378)

* add approximate downsample filter nodelet

* add pcl_voxel_grid_modified package

* fixed cmake list

* use approximate voxel grid filter

* rename packages

* rename voxel grid filter class

Co-authored-by: RyuYamamoto <[email protected]>

* Fix concatenate data (#396)

* Remove std msgs from concatenate data

Signed-off-by: wep21 <[email protected]>

* Adaptive timer

Signed-off-by: wep21 <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

* Sensor data qos (#407)

* Use sensor data qos for pointcloud preprocessor

Signed-off-by: Autoware <[email protected]>

* Use sensor data qos for pointcloud

Signed-off-by: Autoware <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

* Use sensor data qos for livox tag filter and vector map filter

Signed-off-by: wep21 <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Autoware <[email protected]>

* Fix topic name in pointcloud preprocessor (#422)

Signed-off-by: wep21 <[email protected]>

* Fix typo in sensing module (#436)

* Import v0.9.1 (#431)

* add local optimal solution ocillation check to ndt_scan_matcher (#1182)

* Add obstacle_crush diagnostic (#1186)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix diagnostics api (#1185)

* Fix diagnostics api

Signed-off-by: Kenji Miyake <[email protected]>

* Don't overwrite level

Signed-off-by: Kenji Miyake <[email protected]>

* Overwrite level of No Fault diagnostics

Signed-off-by: Kenji Miyake <[email protected]>

* Add missing diag in autoware_error_monitor.yaml (#1187)

Signed-off-by: Kenji Miyake <[email protected]>

* Filter hazard_status (#1191)

* Filter hazard_status

Signed-off-by: Kenji Miyake <[email protected]>

* Filter leaf diagnostics

Signed-off-by: Kenji Miyake <[email protected]>

* Fix wrong calculation of available memory. (#1168)

* Fixed wrong calculation of available memory.

* Added comments about output example of free -tb command.

* Change monitoring method to get HDD temperature and usage per specified device. (#1195)

* Changed monitoring method to get temperature and usage per specified device.

* Fixed test codes.

* Removed unnecessary (void) parameter.

* return input pointcloud when ground plane not found (#1190)

* fix yaw-smoothing bug (#1198)

* Fix lint

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: ito-san <[email protected]>
Co-authored-by: tkimura4 <[email protected]>

* add use_sim-time option (#454)

* Format launch files (#1219)

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for rolling (#1226)

* Replace doc by description

Signed-off-by: Kenji Miyake <[email protected]>

* Replace ns by push-ros-namespace

Signed-off-by: Kenji Miyake <[email protected]>

* Use unique ptr publish in filters (#1240)

Signed-off-by: wep21 <[email protected]>

* Remove invalid warning of concatenate data (#1245)

Signed-off-by: wep21 <[email protected]>

* Unify Apache-2.0 license name (#1242)

* Refine BSD license name (#1244)

* Fix issues in downsample filter (#1253)

* Add missing return statement

* Add override to overridden virtual functions

* Add explicit to the constructor callable with a single argument

* Use using instead of typedef

* Comment out unused function parameters

* Fix cpplint warnings (include-what-you-use)

* Fix uncrustify warnings (except warnings on inclusion guard)

* Add reason why uncrustify excluded

* Add override to overridden virtual function

* change clock of tf_buffer to RCL_ROS_TIME from RCL_SYSTEM_TIME (#1261)

Signed-off-by: Azumi Suzuki <[email protected]>

* Remove use_sim_time for set_parameter (#1260)

Signed-off-by: wep21 <[email protected]>

* Porting small fix (#1288)

* Delete unused code (#1183)

* Fix control topic name of closest_velocity_checker.py (#1174)

Signed-off-by: Kenji Miyake <[email protected]>

* Add comments for livox tag (#1188)

Signed-off-by: Kenji Miyake <[email protected]>

* Clear return value (#1193)

* Change tracker model of unknown object (#1204)

* treat polygon points as relative (#1205)

Signed-off-by: Kosuke Murakami <[email protected]>

* hotfix: reference velocity in consideration of vehicle gear (#1213)

* fix reference velocity for vehicle gear

* add initialization

* revert

* add comment

* change max area param (#1218)

* Fix an identical code for different branches (#1230)

* Update livox_tag_filter.launch.xml

* Fixup

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: shin <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* Fix lint errors (#1378)

* Fix lint errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix variable names

Signed-off-by: Kenji Miyake <[email protected]>

* Use transient_local sub for compare_map_filter (#1437)

* Use transient_local sub for compare_map_filter

Signed-off-by: kosuke55 <[email protected]>

* Rename nn_dists

Signed-off-by: kosuke55 <[email protected]>

* Remove pointcloud_to_laserscan (#1508)

Signed-off-by: wep21 <[email protected]>

* Feature/compare elevation map (#1488)

* suppress warnings for sensing packages (#1729)

* add Werror for tier4_pcl_extensions

* use std::type  instead of pcl::type

* use std::isfinite instead of pcl_isfinite

* fix getFieldIndex

* add Werror

* fix uninitialized

* add Werror

* fix string to char*

* Fix dependency type of rosidl_default_generators (#1801)

* Fix dependency type of rosidl_default_generators

Signed-off-by: Kenji Miyake <[email protected]>

* Remove unnecessary depends

Signed-off-by: Kenji Miyake <[email protected]>

* Use ament_cmake_auto

Signed-off-by: Kenji Miyake <[email protected]>

* Add concatenate_date diagnostic (#1808)

* Add concatenate_date diagnostic

Signed-off-by: kosuke55 <[email protected]>

* Fix spell transed -> transformed

Signed-off-by: kosuke55 <[email protected]>

* Remove unused functions

Signed-off-by: kosuke55 <[email protected]>

* Fix output topic name

Signed-off-by: kosuke55 <[email protected]>

* Remove pub_concat_status

Signed-off-by: kosuke55 <[email protected]>

* Remove concat_num and not_subscribed_topic_names publisher

Signed-off-by: kosuke55 <[email protected]>

* Use set insted of vector

* Refactor daignostics function

* Add const

* Use empty insted of size

* Remove updater_ constructor

* Initialize not_subscribed_topic_names_with input_topics and remove concat_num key-value

* Use ternary operator for diag level and message

* Clarify to use std::string instead of auto

* Use ternary operator for subscribe status

* Add const

* Fix ternary operator

* Change order of diag stat

* Change to subscribe_status

* Fix ternary operator

* Add include set for include_what_you_use

* Fix subscribe_status

* Fix -Wunused-parameter (#1836)

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* fix spell

* Fix lint issues

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore flake8 warnings

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Hiroki OTA <[email protected]>

* Fix compiler warnings (#1837)

* Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-variable

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wformat-security

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winvalid-constexpr

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wdelete-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Winconsistent-missing-override

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <[email protected]>

* Fix "invalid application of 'sizeof' to an incomplete type"

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wgnu-anonymous-struct and -Wnested-anon-types

Signed-off-by: Kenji Miyake <[email protected]>

* Fix lint

Signed-off-by: Kenji Miyake <[email protected]>

* Ignore -Wno-deprecated-declarations in CUDA-related packages

Signed-off-by: Kenji Miyake <[email protected]>

* Fix mistake

Signed-off-by: Kenji Miyake <[email protected]>

* Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

* Fix vector_map_filter downsample (#1847)

* Fix vector_map_filter downsample

Signed-off-by: kosuke55 <[email protected]>

* Fix spell

Signed-off-by: kosuke55 <[email protected]>

* Reserve centralized_cloud

Signed-off-by: kosuke55 <[email protected]>

* Move returning to downsample original coords lines

* Return to the original coords when creating filtered_cloud

* Remove voxel_size_z

* Fix spell

* Remove unnecessary comment

* Remove unnecessary index check

* Remove voxel_size_z in header

* Fix spellcheck fail for some packages (#1842)

* fix transed -> transformed

* fix Urefex to Uref_ex

* fix spell

* Yrefex -> Yref_ex

* add space

* fix for spellcheck

* fix for lint

* fix feedbacked to feedback

* delete Yref_ex

* fix some typos (#1941)

* fix some typos

* fix typo

* Fix typo

Signed-off-by: Kenji Miyake <[email protected]>

Co-authored-by: Kenji Miyake <[email protected]>

* Invoke code formatter at pre-commit (#1935)

* Run ament_uncrustify at pre-commit

* Reformat existing files
* Fix copyright and cpplint errors

Signed-off-by: Kenji Miyake <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

* add sort-package-xml hook in pre-commit (#1881)

* add sort xml hook in pre-commit

* change retval to exit_status

* rename

* add prettier plugin-xml

* use early return

* add license note

* add tier4 license

* restore prettier

* change license order

* move local hooks to public repo

* move prettier-xml to pre-commit-hooks-ros

* update version for bug-fix

* apply pre-commit

* Port filter subscribe and unsbscribe (#2048)

* Port filter subscribe and unsbscribe

Signed-off-by: kosuke55 <[email protected]>

* Add message_filters unsubscribe

* Use filter unsubscribe for compare_elevation_map (#2049)

* Use filter unsubscribe for compare_elevation_map

Signed-off-by: kosuke55 <[email protected]>

* Use override instead of virtual

* Add including header for clang-tidy

* Add missing dependencies of diagnostic_updater (#2242)

Signed-off-by: Kenji Miyake <[email protected]>

* Feature/porting occupancy grid (#1621)

* probabilistic occupancy grid map for blind spot (#1124)

* add probabilistic occupancy grid map

* cosmetic change

* bug fix

* bug fix

* cosmetic change

* cosmetic change

* cosmetic change

* bug fix

* modify topic name and launch

* fix typo

* improve occupancy grid map (#1498)

* use obstacle pointcloud

* fix bug

* update

Signed-off-by: Yukihiro Saito <[email protected]>

* add readme

* modify license and fix bug

* change param

* fix typo

* fix typo

* disable roslint

* cosmetic change

* modify readme

* bug fix (#1514)

* Fix occupancy grid map (#1524)

* bug fix

* cosmetic change

* refactor and bug fix

* Porting occupancy grid to ros2

Signed-off-by: wep21 <[email protected]>

* Fix typo

Signed-off-by: wep21 <[email protected]>

* Fix file name in README

Signed-off-by: wep21 <[email protected]>

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* Feature/porting occupancy grid filter (#1721)

* Feature/occupancy grid map based outlier filter (#1555)

* bug fix

* add occupancy grid map based outlier filter

* cosmetic change

* update occupancy grid map launch

* modify license

* cosmetic change

* disable debug

* fix definition of wrong function

* cosmetic change

Signed-off-by: wep21 <[email protected]>

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

* Update build_depend.repos

Signed-off-by: wep21 <[email protected]>

* Fix message type in readme

Signed-off-by: wep21 <[email protected]>

* Fix topic name in readme

Signed-off-by: wep21 <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Yukihiro Saito <[email protected]>

* Add a new ground filter node (#1509) (#1691)

* Add a new ground filter node (#1509)

* Initial commit

* Implement simple classification method

* Update classification algorithm

* Change virtual ground point to front wheel center

* Update classification algorithm (classify from center of ground points cluster)

* Remove unused code and add some comments.

* Add document and sample launch file

* Fix typo

* Fix typo

* change variable name

* Fix bug

* Fix typo, Fix coding style

* Update params in launch file

* Use autoware_utils::calcDistance3d to calculate distance between two points

* Use radians instead of degrees

* Change default param config

* Add more description about the algorithm

Signed-off-by: wep21 <[email protected]>

* Feature/occupancy grid map based outlier filter (#1555)

* bug fix

* add occupancy grid map based outlier filter

* cosmetic change

* update occupancy grid map launch

* modify license

* cosmetic change

* disable debug

* fix definition of wrong function

* cosmetic change

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

* Fix lint

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>

* Fix build warning (#1745)

Signed-off-by: wep21 <[email protected]>

* Feature/porting occlusion spot (#1740)

* Feature/occlusion_spot safety planner public road (#1594)

* add blind spot safety planner public road

* remove duplicated procesing

* remove unused private param

* renaming fix typo add comments

* fix spell check

* velocity -> relative velocity

* calc2d, To param, simplify search, To original

* add the num possible collision gurd

* computational cost reduction

* Cosmetic change for PossibleCollisionInfo

* add interpolation to possible collision value

* refactor codes

* fix details

* invalid point gurd

* To Param

* refacotor to occlusion spot util

* cosmetic change

* clean up blindspot

* To Occlusion Spot

* revise readme

* refactor drawing

* for better explanation

* fix velocity profile

* clean up details

* cosmetic change for debug marker

* use max velocity in obstacle info instead

* add gtest for Too Many Possible Collision case

* change case

* refactor readme

* minor fix

* add more occlusion spot explanation

* replace svg

* add gtest build path lanelet

* hotfix lateral distance and searching method

* update g test for lateral distance

* use faster search

* set more realistic param

* add lanelet subtype highway

* cosmetic change of reviews

* add occlusion spot module in private area (#1640)

* add occlusion spot in private

* For debugging change

* add spline interpolation to path

* add review changes

* adding minor change

* cosmetic change

* Vector to retval

* Blindspot To OcclusionSpot1

* To Occlusion Spot 2

* To Occlusions spot3

* update gtest with unified anchor

* remove anchor

* add test slice

* simplify interpolation

* Too Occlusion spot4

* add test buffer

* To Occlusion spot

* namespace gurd

* correct slice and add interpolation first

* handle self crossing with check for invation

* to ros debug stream

* removed unused interpolation

* add readme to plant uml

* cosmetic change

* minor change

* update readme

* review change

* change occlusion spot text color

* To Offset no Throw

* better debug marker

* catch only inversion error

* skip return in case of inversion

* for better grid

* simplify path lanelet at first

* remove std::cout

* for better path

* limit ego path inside target lanelet location

* remove last points

* cosmetic change for markers

* apply module for limited scene

* fix interpolation gurd

* for better params

* do not includes path behind

* remove dummy perception publisher

* Revert "remove dummy perception publisher"

This reverts commit 4acad985fe31dd9befaa21a16631495de6c3a117.

* replace hard coded occupancy grid option in psim

* remove respawn

* add arg to params and remove redundunt launch

* fix spell check

* fix default value

Co-authored-by: tkimura4 <[email protected]>

* Feature/occlusion spot private slice size param (#1703)

* add min slice size

* for a bit narrow lateral distance

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/config/occlusion_spot_param.yaml

Co-authored-by: Maxime CLEMENT <[email protected]>

Co-authored-by: Maxime CLEMENT <[email protected]>

* Rename files

Signed-off-by: wep21 <[email protected]>

* Porting to ros2

Signed-off-by: wep21 <[email protected]>

* pre-commit fixes

Signed-off-by: wep21 <[email protected]>

* Fix typo

Signed-off-by: wep21 <[email protected]>

* Fix launch namespace

Co-authored-by: tkimura4 <[email protected]>

* Fix parameter type

Co-authored-by: tkimura4 <[email protected]>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/src/scene_module/occlusion_spot/scene_occlusion_spot_in_private_road.cpp

Co-authored-by: tkimura4 <[email protected]>

Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>

* Fix out of range because of float cast (#1753)

Signed-off-by: wep21 <[email protected]>

* catch exception at look up transform and fix index ROS2 (#1761)

* catch exception at look up transform

* add return to exception case

* fix ament lint

* fix typo and index

* add catch and fix lint

* use catch partly

* error to warn and fix indent

* add child info to logger

* add throttle and return

* Fix compile warnings (#1852)

Fix -Wunused-parameter

Signed-off-by: Kenji Miyake <[email protected]>

Fix -Wunused-private-field

Signed-off-by: Kenji Miyake <[email protected]>

Fix -Wunused-lambda-capture

Signed-off-by: Kenji Miyake <[email protected]>

Fix -Wdelete-non-abstract-non-virtual-dtor

Signed-off-by: Kenji Miyake <[email protected]>

Fix -Wrange-loop-construct

Signed-off-by: Kenji Miyake <[email protected]>

Ignore lint error

Signed-off-by: Kenji Miyake <[email protected]>

* Feature/distortion corrector (#1782)

* Fix/preprocessor format (#1921)

* Enable uncrustify

Signed-off-by: wep21 <[email protected]>

* Apply uncrustify

Signed-off-by: wep21 <[email protected]>

* Feature/left intensity (#1912)

* left intensity

* apply formatting rules

* leave as it is

* rename function

* Update occ grid docs (#1991)

* update docs

* cosmetic change

* update readme (#1992)

* Apply format (#1999)

Signed-off-by: Kenji Miyake <[email protected]>

Fix cpplint

Signed-off-by: Kenji Miyake <[email protected]>

* Fix/ground filter classification algorithm (#2038)

* Check the distance from object cluster for non ground following points to calculate the slope

* fix cpplint error

* fix cpplint error

* Fix package.xml (#2056)

Signed-off-by: Kenji Miyake <[email protected]>

* Feature/port dual return filter (#2020)

* Original commit, with basic weak first filtering

* Add simple diagnostic, ring outlier for normal points, format

* Separate weak first and normal point ring outlier filter parameters, update published topics for investigation

* rename header

* porting

* add config file

* add launch

* visiblity and noise

* add missing subscribe function

* remove unnecessary subscriber

* add publishing topic

* add visiblity diag

* enable image transport

* minor fix

* uncrusify

* add image transport

* add visiblity thresh param

* typo fix

* add dynamic reconf param

* tmp_dual_echo

* point cloud type fix

* cosmetic change

* precommit

* Update sensing/preprocessor/pointcloud/pointcloud_preprocessor/include/pointcloud_preprocessor/outlier_filter/dual_return_outlier_filter_nodelet.hpp

Co-authored-by: davidw <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>

* add key value (#2209)

* add key value

* Update sensing/preprocessor/pointcloud/pointcloud_preprocessor/src/outlier_filter/dual_return_outlier_filter_nodelet.cpp

Co-authored-by: Kenji Miyake <[email protected]>

* cosmetic change

Co-authored-by: Kenji Miyake <[email protected]>

* Change formatter to clang-format and black (#2332)

* Revert "Temporarily comment out pre-commit hooks"

This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3.

* Replace ament_lint_common with autoware_lint_common

Signed-off-by: Kenji Miyake <[email protected]>

* Remove ament_cmake_uncrustify and ament_clang_format

Signed-off-by: Kenji Miyake <[email protected]>

* Apply Black

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Fix for cpplint

* Fix include double quotes to angle brackets

Signed-off-by: Kenji Miyake <[email protected]>

* Apply clang-format

Signed-off-by: Kenji Miyake <[email protected]>

* Fix build errors

Signed-off-by: Kenji Miyake <[email protected]>

* Add COLCON_IGNORE (#500)

Signed-off-by: Kenji Miyake <[email protected]>

* port vector map filter (#507)

* remove COLCON_IGNORE

* use HADMapBin.idl

* remove COLCON_IGNORE (#515)

* port ground/compare map filter for perception as segmentation stack (#490)

* move ground filter to perception from sensing

* cleanup ground filter launch file

* remove ground filter from sensing

* refer pointclound_preprocessor/filter.hpp

* rename package ground_filter -> ground_segmentation

* add compare_map_filter into object_segmentation as compare_map_segmentation

* fix include guard in ground segmentation

* cleanup readme

* remove compare map filter from sensing stack

* remove unnecessary dependency

* remove more depends

* remove std_msgs from pkg depends

* [ polar grid ] add readme polar grid remove colcon ignore (#559)

* remove ignore

* add readme

* fix invalid link

* [vehicle_info_util] add readme (#560)

* add readme

* fix typo

* replace to valid link

* doc livox tag filter (#594)

* add minimal doc

* fix doc

* doc tier4 pcl extensions (#598)

* use velocity report (#596)

* use velocity report

* remove velocity report porting from gyro_odometor

Co-authored-by: Takayuki Murooka <[email protected]>

* Remove template comments from node documents (#608)

* rename document file

* remove template comment

* Auto/document pointclound preprocessor (#607)

* add document template

* minimal doc

* rm dust

* fix path

* add minimal description

* update parameter description

* update porpose

* update document title

* fix typo

* fix outlier filter doc

* update crop-box-filter & concatenate-data

* fix typo

* add distortion corrector

* fix topic type

* add passthrough filter doc

* add vector map filter doc

* add point cloud preprocessor doc

* add downsampling doc

* fix broken link

* fix wrong input topic (#647)

* update to support velocity report header (#655)

* update to support velocity report header

Signed-off-by: Takamasa Horibe <[email protected]>

* Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

Co-authored-by: tkimura4 <[email protected]>

* use maybe_unused

Signed-off-by: Takamasa Horibe <[email protected]>

* fix precommit

Signed-off-by: Takamasa Horibe <[email protected]>

Co-authored-by: tkimura4 <[email protected]>

* adapt to actuation cmd/status as control msg (#646)

* adapt to actuation cmd/status as control msg

* fix readme

* fix topics

* fix remaing topics

* as to pacmod interface

* fix vehicle status

* add header to twist

* revert gyro_odometer_change

* revert twist topic change

* revert unchanged package

* initialize pointer (#660)

* add tf2_geometry_msgs include to distorction_filter (#664)

* add tf2_geometry_msgs include

* add tf2_geometry_msgs pkg depend

* Sync .auto branch with the latest branch in internal repository (#691)

* add trajectory point offset in rviz plugin (#2270)

* sync rc rc/v0.23.0 (#2258)

* fix interpolation for insert point (#2228)

* fix interpolation for insert point

* to prev interpolation pkg

* Revert "to prev interpolation pkg"

This reverts commit 9eb145b5d36e297186015fb17c267ccd5b3c21ef.

Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: taikitanaka <[email protected]>

* fix topic name (#2266)

Signed-off-by: Takamasa Horibe <[email protected]>

* Add namespace to diag for dual_return_filter (#2269)

* Add a function to make 'geometry_msgs::msg::TransformStamped' (#2250)

* Add a function to make 'geometry_msgs::msg::TransformStamped'
* Add 'child_frame_id' as an argument of 'pose2transform'

* Simplify marker scale initialization (#2286)

* Fix/crosswalk polygon (#2279)

* extend crosswalk polygon

* improve readability

* fix polygon shape

* Add warning when decel distance calculation fails (#2289)

Signed-off-by: Makoto Kurihara <[email protected]>

* [motion_velocity_smoother] ignore debug print (#2292)

* cosmetic change

Signed-off-by: Takamasa Horibe <[email protected]>

* cahnge severity from WARN to DEBUG for debug info

Signed-off-by: Takamasa Horibe <[email protected]>

* use util for stop_watch

Signed-off-by: Takamasa Horibe <[email protected]>

* fix map based prediction (#2200)

* fix map based prediction

* fix format

* change map based prediction

* fix spells

* fix spells in comments

* fix for cpplint

* fix some problems

* fix format and code for clang-tidy

* fix space for cpplint

* Update Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

* fix vector access method

* fix readme format

* add parameter

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

Co-authored-by: Kazuki Miyahara <[email protected]>

* Update Readme.md

* Update perception/object_recognition/prediction/map_based_prediction/Readme.md

Co-authored-by: Kazuki Miyahara <[email protected]>

Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

* remove failure condition for 0 velocity trajectory (#2295)

Signed-off-by: Takamasa Horibe <[email protected]>

* [mpc_follower] remove stop distance condition from stopState decision (#1916)

* [mpc_follower] remove stop distance condition from stopState decision

Signed-off-by: Takamasa Horibe <[email protected]>

* add invalid index handling

Signed-off-by: Takamasa Horibe <[email protected]>

* Move the debug marker initialization part to another file (#2288)

* Move the debug marker initialization part to 'debug.cpp'

* Make 'isLocalOptimalSolutionOscillation' independent from 'NDTScanMatcher' (#2300)

* Remove an unused function 'getTransform' (#2301)

* Simplify iteration of initial poses (#2310)

* Make a transform object const (#2311)

* Represent poses in 'std::vector' instead of 'geometry_msgs::msg::PoseArray' (#2312)

* Feature/no stopping area (#2163)

* add no stopping area module to behavior velocity planner

* apply utils

* add polygon interpolation module order stopline around area is considered

* devide jpass udge with stop line polygon

* update docs

* rename file name

* update to latest

* minor change for marker

* update license

Co-authored-by: Yukihiro Saito <[email protected]>

* update license

Co-authored-by: Yukihiro Saito <[email protected]>

* update license

Co-authored-by: Yukihiro Saito <[email protected]>

* update license

Co-authored-by: Yukihiro Saito <[email protected]>

* minor fix

* add parameter tuning at experiment

* update readme

* format doc

* apply comments

* add exception gurd

* cosmetic change

* fix ament

* fix typo and remove for statement

* & to " "

* better ns

* return pass judge param

* add missing stoppable condition

* add clear pass judge and stoppable flag

* add comment

* precommit fix

* cpplint

Co-authored-by: Yukihiro Saito <[email protected]>

* sync rc rc/v0.23.0 (#2281)

* Fix side shift planner (#2171) (#2172)

* add print debug

Signed-off-by: TakaHoribe <[email protected]>

* remove forward shift points when adding new point

Signed-off-by: TakaHoribe <[email protected]>

* remove debug print

Signed-off-by: TakaHoribe <[email protected]>

* format

Signed-off-by: TakaHoribe <[email protected]>

* Fix remove threshold

Co-authored-by: Fumiya Watanabe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>

* Fix/pull out and pull over (#2175)

* delete unnecessary check

* fix condition of starting pull out

* Add emergency status API (#2174) (#2182)

* Fix/mpc reset prev result (#2185) (#2195)

* reset prev result

* clean code

* reset only raw_steer_cmd

* Update control/mpc_follower/src/mpc_follower_core.cpp

Co-authored-by: Takamasa Horibe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>

* [hotfix] 1 path point exception after resampling (#2204)

* fix 1 path point exception after resampling

Signed-off-by: TakaHoribe <[email protected]>

* Apply suggestions from code review

* Apply suggestions from code review

Co-authored-by: Takamasa Horibe <[email protected]>

Co-authored-by: tkimura4 <[email protected]>

* [hotfix] Fix lane ids (#2211)

* Fix lane ids

* Prevent acceleration on avoidance (#2214)

* prevent acceleration on avoidance

Signed-off-by: TakaHoribe <[email protected]>

* fix param name

Signed-off-by: TakaHoribe <[email protected]>

* parametrize avoidance acc

Signed-off-by: Takamasa Horibe <[email protected]>

* change param name

Signed-off-by: Takamasa Horibe <[email protected]>

* fix typo

Signed-off-by: Takamasa Horibe <[email protected]>

* Fix qos in roi cluster fusion (#2218)

* fix confidence (#2220)

* too high confidence (#2229)

* Fix/obstacle stop 0.23.0 (#2232)

* fix unexpected slow down in sharp curves (#2181)

* Fix/insert implementation (#2186)

Co-authored-by: Satoshi OTA <[email protected]>

* [hotfix] Remove exception in avoidance module (#2233)

* Remove exception

* Fix clock

* Remove blank line

* Update traffic light state if ref stop point is ahead of previous one (#2197)

Signed-off-by: wep21 <[email protected]>

* fix interpolation for insert point (#2228)

* fix interpolation for insert point

* to prev interpolation pkg

* fix index (#2265)

* turn signal calculation (#2280)

* add turn signal funtion in path shifter

* add ros parameters

Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: Sugatyon <[email protected]>

* [behavior_path_planner] fix sudden path change around ego (#2305) (#2318)

* fix return-from-ego shift point generation logic

Signed-off-by: Takamasa Horibe <[email protected]>

* change param for trimSimilarGradShiftPoint

Signed-off-by: Takamasa Horibe <[email protected]>

* add comment for issue

Signed-off-by: Takamasa Horibe <[email protected]>

* update comment

Signed-off-by: Takamasa Horibe <[email protected]>

* replace code with function (logic has not changed)

Signed-off-by: Takamasa Horibe <[email protected]>

* move func to cpp

Signed-off-by: Takamasa Horibe <[email protected]>

* add comment for issue

Signed-off-by: Takamasa Horibe <[email protected]>

* fix typo

Signed-off-by: Takamasa Horibe <[email protected]>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Kazuki Miyahara <[email protected]>

* Update planning/scenario_planning/lane_driving/behavior_planning/behavior_path_planner/src/scene_module/avoidance/avoidance_module.cpp

Co-authored-by: Kazuki Miyahara <[email protected]>

Co-authored-by: Kazuki Miyahara <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>

* Add functions to make stamped scalar messages (#2317)

* Fix/object yaw in intersection module (#2294)

* fix object orientation

* fix function name

* add guard (#2321)

* reduce cost (double to float) (#2298)

* Add detail collision check (#2274)

* Add detail collision check

Signed-off-by: wep21 <[email protected]>

* Remove unused function

Signed-off-by: wep21 <[email protected]>

* Fix arc length

Signed-off-by: wep21 <[email protected]>

* Seperate time margin

Signed-off-by: wep21 <[email protected]>

* Fix parameter name

Signed-off-by: wep21 <[email protected]>

* Update Readme

Signed-off-by: wep21 <[email protected]>

* Address review: Add comment for TimeDistanceArray

Signed-off-by: wep21 <[email protected]>

* Run pre-commit

Signed-off-by: wep21 <[email protected]>

* Fix cpplint

Signed-off-by: wep21 <[email protected]>

* Add return for empty polygon

Signed-off-by: wep21 <[email protected]>

* update CenterPoint  (#2222)

* update to model trained by mmdet3d

* add vizualizer (debug)

* for multi-frame inputs

* chagne config

* use autoware_utils::pi

* project specific model and param

* rename vfe -> encoder

* rename general to common

* update download link

* update

* fix

* rename model_name

* change training toolbox link

* chage lint package

* fix test error

* commit suggestion

* Feature/lane change detection (#2331)

* add old information deleter

* fix access bug

* change to deque

* update obstacle buffer

* fix some bugs

* add lane change detector

* make a update lanelet function

* fix code style

* parameterize essential values

* Update perception/object_recognition/prediction/map_based_prediction/src/map_based_prediction_ros.cpp

Co-authored-by: Kazuki Miyahara <[email protected]>

* fix slash position

* remove unnecessary lines

* fix format

* fix format

* change to new enum

* fix format

* fix typo and add guard

* change funciton name

* add lane change description

Co-authored-by: Kazuki Miyahara <[email protected]>

* Add Planning Evaluator  (#2293)

* Add prototype planning evaluator

Produced data for dist between points, curvature, and relative angle

* Cleanup the code to make adding metrics easier

* Add remaining basic metrics (length, duration, vel, accel, jerk)

* Add motion_evaluator to evaluate the actual ego motion + code cleanup

* Add deviation metrics

* Add naive stability metric

* Handle invalid stat (TODO: fix the output file formatting)

* Add parameter file and cleanup

* Add basic obstacle metric (TTC not yet implemented) and fix output file format

* Add basic time to collision

* Add lateral-distance based stability metric

* Add check (at init time) that metrics' maps are complete

* Publish metrics as ParamaterDeclaration msg (for openscenario)

* Use lookahead and start from ego_pose when calculating stability metrics

* Code cleanup

* Fix lint

* Add tests

* Fix bug with Frechet dist and the last traj point

* Finish implementing tests

* Fix lint

* Code cleanup

* Update README.md

* Remove unused metric

* Change msg type of published metrics to DiagnosticArray

* fix format to fix pre-commit check

Signed-off-by: Takamasa Horibe <[email protected]>

* fix yaml format to fix pre-commit check

Signed-off-by: Takamasa Horibe <[email protected]>

* fix yaml format

Signed-off-by: Takamasa Horibe <[email protected]>

* apply clang-format

Signed-off-by: Takamasa Horibe <[email protected]>

* apply clang-format

Signed-off-by: Takamasa Horibe <[email protected]>

* Update planning/planning_diagnostics/planning_evaluator/include/planning_evaluator/planning_evaluator_node.hpp

* Update planning/planning_diagnostics/planning_evaluator/test/test_planning_evaluator_node.cpp

* Update planning/planning_diagnostics/planning_evaluator/test/test_planning_evaluator_node.cpp

* change lint format to autoware_lint_common

Signed-off-by: Takamasa Horibe <[email protected]>

Co-authored-by: Takamasa Horibe <[email protected]>

* Add keep braking function at driving state (#2346)

* Add keep braking function at driving state

Signed-off-by: Makoto Kurihara <[email protected]>

* Remove debug messages

Signed-off-by: Makoto Kurihara <[email protected]>

* Fix format

Signed-off-by: Makoto Kurihara <[email protected]>

* Change diag_updater's pediod from default to 0.1sec (#2348)

* add cross judgement and common signal function (#2319)

* merge branch turn_signal_common

* add turn signal function in signal decider

* add cross judge in path_utilities and delete from turn_signal_decider

* remove original signal calculation in lane change

* omit substitution

* replace turn signal decider in pull over function

* modify cross judge logic

* replace turn signal decider in avoidance

* add readme of turn signal

* update

* delete print debug

* update

* delete lane change decider in path shifter

* delete blank line

* fix indent

* fix typo

* fix typo

* decrease nest

* run pre commit

* Add 0 limit at forward jerk velocity filter (#2340)

Signed-off-by: Makoto Kurihara <[email protected]>

* add time offset param to point cloud concatenation (#2303)

* add offset param

* clang-format

Co-authored-by: Akihito OHSATO <[email protected]>

* Feature/add doc for keep braking function at driving state (#2366)

* Add the description of brake keeping

Signed-off-by: Makoto Kurihara <[email protected]>

* Add the english document

Signed-off-by: Makoto Kurihara <[email protected]>

* Improve description

Signed-off-by: Makoto Kurihara <[email protected]>

* Add english description

Signed-off-by: Makoto Kurihara <[email protected]>

* Fix include files (#2339)

Signed-off-by: Kenji Miyake <[email protected]>

* fix behavior intersection module

* fix behavior no stopping area module

* fix planning_evaluator

* fix motion_velocity_smoother

* rename variable

* Revert "[mpc_follower] remove stop distance condition from stopState decision (#1916)"

This reverts commit ff4f0b5a844d1f835f1b93bd3b36a76747b0cd02.

* Revert "Add keep braking function at driving state (#2346)"

This reverts commit f0478187db4c28bf6092c198723dcc5ec11a9c70.

* Revert "Feature/add doc for keep braking function at driving state (#2366)"

This reverts commit 66de2f3924a479049fce2d5c5c6b579cacbd3e49.

* Fix orientation availability in centerpoint

Signed-off-by: wep21 <[email protected]>

* fix test_trajectory.cpp

* add target link libraries

* Use .auto msg in test code for planniing evaluator

Signed-off-by: wep21 <[email protected]>

* fix include

Signed-off-by: wep21 <[email protected]>

Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: taikitanaka <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Takeshi Miura <[email protected]>
Co-authored-by: Takeshi Ishita <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: purewater0901 <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Sugatyon <[email protected]>
Co-authored-by: s-murakami-esol <[email protected]>
Co-authored-by: Yusuke Muramatsu <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
Co-authored-by: Akihito OHSATO <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>

Co-authored-by: mitsudome-r <[email protected]>
Co-authored-by: Taichi Higashide <[email protected]>
Co-authored-by: YamatoAndo <[email protected]>
Co-authored-by: Yukihiro Saito <[email protected]>
Co-authored-by: Daichi Murakami <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Nikolai Morin <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: Frederik Beaujean <[email protected]>
Co-authored-by: Jilada Eccleston <[email protected]>
Co-authored-by: Ryohsuke Mitsudome <[email protected]>
Co-authored-by: Autoware <[email protected]>
Co-authored-by: Kosuke Murakami <[email protected]>
Co-authored-by: Daisuke Nishimatsu <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
Co-authored-by: RyuYamamoto <[email protected]>
Co-authored-by: Kazuki Miyahara <[email protected]>
Co-authored-by: ito-san <[email protected]>
Co-authored-by: tkimura4 <[email protected]>
Co-authored-by: s-azumi <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: shin <[email protected]>
Co-authored-by: Fumiya Watanabe <[email protected]>
Co-authored-by: Hiroki OTA <[email protected]>
Co-authored-by: Kenji Miyake <[email protected]>
Co-authored-by: Kosuke Takeuchi <[email protected]>
Co-authored-by: Takeshi Ishita <[email protected]>
Co-authored-by: Keisuke Shima <[email protected]>
Co-authored-by: Shunsuke Miura <[email protected]>
Co-authored-by: Maxime CLEMENT <[email protected]>
Co-authored-by: davidw <[email protected]>
Co-authored-by: Shinnosuke Hirakawa <[email protected]>
Co-authored-by: Satoshi OTA <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: autoware-iv-sync-ci[bot] <87871706+autoware-iv-sync-ci[bot]@users.noreply.github.com>
Co-authored-by: taikitanaka <[email protected]>
Co-authored-by: Makoto Kurihara <[email protected]>
Co-authored-by: purewater0901 <[email protected]>
Co-authored-by: Takagi, Isamu <[email protected]>
Co-authored-by: Sugatyon <[email protected]>
Co-authored-by: s-murakami-esol <[email protected]>
Co-authored-by: Yusuke Muramatsu <[email protected]>
Co-authored-by: Akihito OHSATO <[email protected]>
isamu-takagi pushed a commit to isamu-takagi/autoware.universe that referenced this pull request Apr 21, 2022
@tkimura4 @takayuki5168
@TakaHoribe @taikitanaka3
feat: add pacmod_interface package (autowarefoundation#125)
0b8fd6b 
* split as into pacmod_interface and ssc_interface (autowarefoundation#640)

* split as into pacmod_interface and ssc_interface

* remove as and move config

Co-authored-by: Takayuki Murooka <[email protected]>

* update to support velocity report header (autowarefoundation#655)

* update to support velocity report header

Signed-off-by: Takamasa Horibe <[email protected]>

* Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp

Co-authored-by: tkimura4 <[email protected]>

* use maybe_unused

Signed-off-by: Takamasa Horibe <[email protected]>

* fix precommit

Signed-off-by: Takamasa Horibe <[email protected]>

Co-authored-by: tkimura4 <[email protected]>

* adapt to actuation cmd/status as control msg (autowarefoundation#646)

* adapt to actuation cmd/status as control msg

* fix readme

* fix topics

* fix remaing topics

* as to pacmod interface

* fix vehicle status

* add header to twist

* revert gyro_odometer_change

* revert twist topic change

* revert unchanged package

* [pacmod_interface]fix topic name (autowarefoundation#651)

* fix topic name

* fix ns

* fix

* auto/revert cmd converter (autowarefoundation#680)

* Revert "move cmd converters to control pkg (autowarefoundation#642)"

This reverts commit 9f733b5.

* fix topic

* add as doc (autowarefoundation#616)

* add as doc

* pacmod_msgs -> pacmod3_msgs

* fix typo

* update topic names of README.md

* update README.md

Co-authored-by: Takayuki Murooka <[email protected]>

* Auto/steering wheel status (autowarefoundation#719)

* unused

* add stering wheel status

* fix current steer

* publish turn cmd (autowarefoundation#749)

* fix typo

Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takayuki Murooka <[email protected]>
Co-authored-by: Takamasa Horibe <[email protected]>
Co-authored-by: taikitanaka3 <[email protected]>
badai-nguyen pushed a commit to badai-nguyen/autoware.universe that referenced this pull request Aug 15, 2023
@tkimura4
Merge pull request autowarefoundation#719 from tier4/hotfix/perception
0a4b9e2 
fix(image_projection_based_fusion, tier4_perception_launch): update camera-lidar-fusion based detection
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@esteve esteve esteve requested changes

@kenji-miyake kenji-miyake Awaiting requested review from kenji-miyake

Assignees
No one assigned
Labels
ros:humble ROS Humble Hawksbill release. ros:rolling Continuous ROS Rolling Ridley release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wep21 @esteve