-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new diag for hdd_monitor to diagnostics aggregator #642
Conversation
Codecov Report
@@ Coverage Diff @@
## main #642 +/- ##
=======================================
Coverage 10.66% 10.66%
=======================================
Files 729 729
Lines 51075 51075
Branches 6572 6572
=======================================
Hits 5445 5445
Misses 41223 41223
Partials 4407 4407
*This pull request uses carry forward flags. Click here to find out more. Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! I will make sure to support diagnostic_aggregator
here if diagnostic items are added.
LGTM |
* release v0.4.0 * remove ROS1 packages temporarily Signed-off-by: mitsudome-r <[email protected]> * Revert "remove ROS1 packages temporarily" This reverts commit a2dc52036f5950188b5b4caedb2edcd36d3e5860. Signed-off-by: mitsudome-r <[email protected]> * add COLCON_IGNORE to ros1 packages Signed-off-by: mitsudome-r <[email protected]> * ROS2 Porting: raw_vehicle_cmd_converter (autowarefoundation#9) * remove dependency to unused std_msgs package Signed-off-by: mitsudome-r <[email protected]> * rm COLCON_IGNORE Signed-off-by: mitsudome-r <[email protected]> * port raw_vehicle_cmd_converter to ROS2 Signed-off-by: mitsudome-r <[email protected]> * port raw_vehicle_cmd_converter.launch to ROS2 Signed-off-by: mitsudome-r <[email protected]> * fix typo Co-authored-by: Frederik Beaujean <[email protected]> * fix typo Co-authored-by: Frederik Beaujean <[email protected]> * remove include_directories form CMakeLists.txt Signed-off-by: mitsudome-r <[email protected]> * fix order of includes Signed-off-by: mitsudome-r <[email protected]> * add missing comments Signed-off-by: mitsudome-r <[email protected]> Co-authored-by: Frederik Beaujean <[email protected]> * fix duration unit for RCLCPP_*_THROTTLE (autowarefoundation#75) Signed-off-by: Takamasa Horibe <[email protected]> * Rename h files to hpp (autowarefoundation#142) * Change includes * Rename files * Adjustments to make things compile * Other packages * Adjust copyright notice on 532 out of 699 source files (autowarefoundation#143) * Use quotes for includes where appropriate (autowarefoundation#144) * Use quotes for includes where appropriate * Fix lint tests * Make tests pass hopefully * Run uncrustify on the entire Pilot.Auto codebase (autowarefoundation#151) * Run uncrustify on the entire Pilot.Auto codebase * Exclude open PRs * ROS2 Linting: raw_vehicle_cmd_converter (autowarefoundation#161) * Add linters * Process linter corrections * apply env_var to use_sim_time (autowarefoundation#222) * Ros2 v0.8.0 raw vehicle cmd converter (autowarefoundation#268) * restore raw_vehicle_cmd_converter files for 0.8.0 update Signed-off-by: Takamasa Horibe <[email protected]> * fix typos in vehicle modules (autowarefoundation#954) * add get func (autowarefoundation#1088) * Revert "restore raw_vehicle_cmd_converter files for 0.8.0 update" This reverts commit f243f26e20490757a332566aa92196553a682aa6. Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: tkimura4 <[email protected]> * update target branch for ci (autowarefoundation#309) * update target branch for ci Signed-off-by: mitsudome-r <[email protected]> * [as]: Fix lint Signed-off-by: wep21 <[email protected]> * [latlon_muxer]: Fix lint Signed-off-by: wep21 <[email protected]> * [map_based_prediction]: Fix lint Signed-off-by: wep21 <[email protected]> * [raw_vehicle_cmd_converter]: Fix lint Signed-off-by: wep21 <[email protected]> * [remote_cmd_converter]: Fix lint Signed-off-by: wep21 <[email protected]> * [turn_signal_decider]: Fix lint Signed-off-by: wep21 <[email protected]> Co-authored-by: wep21 <[email protected]> * Unify Apache-2.0 license name (autowarefoundation#1242) * Remove use_sim_time for set_parameter (autowarefoundation#1260) Signed-off-by: wep21 <[email protected]> * add plot_accel_brake_map.py (autowarefoundation#1249) (autowarefoundation#1296) * add plot_accel_brake_map.py (autowarefoundation#1249) * add plot_accel_brake_map.py * call plotter from rosrun * add permission Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> * delete debug message * Add license Signed-off-by: wep21 <[email protected]> * apply format * fix code Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: wep21 <[email protected]> Co-authored-by: tomoya.kimura <[email protected]> * Fix lint errors (autowarefoundation#1378) * Fix lint errors Signed-off-by: Kenji Miyake <[email protected]> * Fix variable names Signed-off-by: Kenji Miyake <[email protected]> * enable to designate directory of maps (autowarefoundation#1301) (autowarefoundation#1480) * enable to designate directory of maps * add error handling * use argparser Co-authored-by: Takayuki Murooka <[email protected]> * Fix -Wunused-parameter (autowarefoundation#1836) * Fix -Wunused-parameter Signed-off-by: Kenji Miyake <[email protected]> * Fix mistake Signed-off-by: Kenji Miyake <[email protected]> * fix spell * Fix lint issues Signed-off-by: Kenji Miyake <[email protected]> * Ignore flake8 warnings Signed-off-by: Kenji Miyake <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit * Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688) * Feature/vehicle interface improvements (autowarefoundation#1361) * add vehicle msg * add pacmod interface * add eps controller * use each control commands instead of vehicle command * fixed details * fixed speell check * const * fixed brake status * publish cmd when recieving ctrl cmd * fix shift cmd ptr * remove unused function and set proper license * fix names * fix typo for pacmod * remove unnecessary waiting * use flags, limit, multiarray * remove accel brake dependency * fix retrun value * replace eps to steer * cosmetic change for namespace * fix segfo and retval * Use Enum instead of int * remove unused var * add const * rename to calcFFMap * prev time steer calc * add sample csv * add new line Signed-off-by: wep21 <[email protected]> * Apply lint Signed-off-by: wep21 <[email protected]> * Fix build failure for remote cmd converter Signed-off-by: wep21 <[email protected]> * Fix lint Signed-off-by: wep21 <[email protected]> * replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717) * Fix subscriber topic type Co-authored-by: tkimura4 <[email protected]> * Fix rclcpp::Time initialization Co-authored-by: tkimura4 <[email protected]> Co-authored-by: tkimura4 <[email protected]> * default debug value false in raw vehicle cmd converter (autowarefoundation#1755) * default debug value false in raw vehicle cmd converter * spell check * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> * [raw vehicle cmd converter] apply autoware auto msgs (autowarefoundation#519) * remove ignore * replace to autoware auto control message * use localization odometry * apply steering report * appluy clang format * cosmetic change * fix spell check * update to readme * update launch * minor fix * precommit fix * update README.md Co-authored-by: tkimura4 <[email protected]> * using AckermannControlCommand * fix format Co-authored-by: tkimura4 <[email protected]> * move cmd converters to control pkg (autowarefoundation#642) * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit 19a10f9419aa25ef7a37e51c5df8f65b75cf8887. * fix topic * Auto/readme cmd converter (autowarefoundation#692) * fix format * add readme external cmd converter * fix lint * fiix sentence Co-authored-by: Kazuki Miyahara <[email protected]> * fix format Co-authored-by: Kazuki Miyahara <[email protected]> * fix sentence Co-authored-by: Kazuki Miyahara <[email protected]> * better expression Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> * fix door cmd topic (autowarefoundation#711) * fix door cmd topic * fix topic Co-authored-by: mitsudome-r <[email protected]> Co-authored-by: Ryohsuke Mitsudome <[email protected]> Co-authored-by: Frederik Beaujean <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: Nikolai Morin <[email protected]> Co-authored-by: Jilada Eccleston <[email protected]> Co-authored-by: Kosuke Murakami <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: tkimura4 <[email protected]> Co-authored-by: wep21 <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Hiroki OTA <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Takeshi Miura <[email protected]>
* Add autoware api (autowarefoundation#1979) Signed-off-by: tanaka3 <[email protected]> * Use EmergencyState instead of deprecated EmergencyMode (autowarefoundation#2030) * Use EmergencyState instead of deprecated EmergencyMode Signed-off-by: Kenji Miyake <[email protected]> * Use stamped type Signed-off-by: Kenji Miyake <[email protected]> Signed-off-by: tanaka3 <[email protected]> * add sort-package-xml hook in pre-commit (autowarefoundation#1881) * add sort xml hook in pre-commit * change retval to exit_status * rename * add prettier plugin-xml * use early return * add license note * add tier4 license * restore prettier * change license order * move local hooks to public repo * move prettier-xml to pre-commit-hooks-ros * update version for bug-fix * apply pre-commit Signed-off-by: tanaka3 <[email protected]> * Add selected external command API (autowarefoundation#2053) Signed-off-by: tanaka3 <[email protected]> * Feature/vehicle interface improvements (autowarefoundation#1361) (autowarefoundation#1688) * Feature/vehicle interface improvements (autowarefoundation#1361) * add vehicle msg * add pacmod interface * add eps controller * use each control commands instead of vehicle command * fixed details * fixed speell check * const * fixed brake status * publish cmd when recieving ctrl cmd * fix shift cmd ptr * remove unused function and set proper license * fix names * fix typo for pacmod * remove unnecessary waiting * use flags, limit, multiarray * remove accel brake dependency * fix retrun value * replace eps to steer * cosmetic change for namespace * fix segfo and retval * Use Enum instead of int * remove unused var * add const * rename to calcFFMap * prev time steer calc * add sample csv * add new line Signed-off-by: wep21 <[email protected]> * Apply lint Signed-off-by: wep21 <[email protected]> * Fix build failure for remote cmd converter Signed-off-by: wep21 <[email protected]> * Fix lint Signed-off-by: wep21 <[email protected]> * replace to vehicle cmd emergency (autowarefoundation#1710) (autowarefoundation#1717) * Fix subscriber topic type Co-authored-by: tkimura4 <[email protected]> * Fix rclcpp::Time initialization Co-authored-by: tkimura4 <[email protected]> Co-authored-by: tkimura4 <[email protected]> Signed-off-by: tanaka3 <[email protected]> * Change formatter to clang-format and black (autowarefoundation#2332) * Revert "Temporarily comment out pre-commit hooks" This reverts commit 748e9cdb145ce12f8b520bcbd97f5ff899fc28a3. * Replace ament_lint_common with autoware_lint_common Signed-off-by: Kenji Miyake <[email protected]> * Remove ament_cmake_uncrustify and ament_clang_format Signed-off-by: Kenji Miyake <[email protected]> * Apply Black Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> * Fix for cpplint * Fix include double quotes to angle brackets Signed-off-by: Kenji Miyake <[email protected]> * Apply clang-format Signed-off-by: Kenji Miyake <[email protected]> * Fix build errors Signed-off-by: Kenji Miyake <[email protected]> Signed-off-by: tanaka3 <[email protected]> * Add COLCON_IGNORE (autowarefoundation#500) Signed-off-by: Kenji Miyake <[email protected]> Signed-off-by: tanaka3 <[email protected]> * [external_cmd_converter] apply autoware auto msgs (autowarefoundation#535) * remove ignore * apply auto msgs * modify launch * topic to shift command Signed-off-by: tanaka3 <[email protected]> * move cmd converters to control pkg (autowarefoundation#642) Signed-off-by: tanaka3 <[email protected]> * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit aed827c4fdfa01cc7bc29e70307d5e2cbc8aa8d3. * fix topic Signed-off-by: tanaka3 <[email protected]> * fix shift to gear (autowarefoundation#683) Signed-off-by: tanaka3 <[email protected]> * Auto/readme cmd converter (autowarefoundation#692) * fix format * add readme external cmd converter * fix lint * fiix sentence Co-authored-by: Kazuki Miyahara <[email protected]> * fix format Co-authored-by: Kazuki Miyahara <[email protected]> * fix sentence Co-authored-by: Kazuki Miyahara <[email protected]> * better expression Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Signed-off-by: tanaka3 <[email protected]> Co-authored-by: Takagi, Isamu <[email protected]> Co-authored-by: Kenji Miyake <[email protected]> Co-authored-by: Keisuke Shima <[email protected]> Co-authored-by: Daisuke Nishimatsu <[email protected]> Co-authored-by: tkimura4 <[email protected]> Co-authored-by: taikitanaka3 <[email protected]> Co-authored-by: Kazuki Miyahara <[email protected]> Co-authored-by: Takeshi Miura <[email protected]>
* split as into pacmod_interface and ssc_interface (autowarefoundation#640) * split as into pacmod_interface and ssc_interface * remove as and move config Co-authored-by: Takayuki Murooka <[email protected]> * update to support velocity report header (autowarefoundation#655) * update to support velocity report header Signed-off-by: Takamasa Horibe <[email protected]> * Update simulator/simple_planning_simulator/src/simple_planning_simulator/simple_planning_simulator_core.cpp Co-authored-by: tkimura4 <[email protected]> * use maybe_unused Signed-off-by: Takamasa Horibe <[email protected]> * fix precommit Signed-off-by: Takamasa Horibe <[email protected]> Co-authored-by: tkimura4 <[email protected]> * adapt to actuation cmd/status as control msg (autowarefoundation#646) * adapt to actuation cmd/status as control msg * fix readme * fix topics * fix remaing topics * as to pacmod interface * fix vehicle status * add header to twist * revert gyro_odometer_change * revert twist topic change * revert unchanged package * [pacmod_interface]fix topic name (autowarefoundation#651) * fix topic name * fix ns * fix * auto/revert cmd converter (autowarefoundation#680) * Revert "move cmd converters to control pkg (autowarefoundation#642)" This reverts commit 9f733b5. * fix topic * add as doc (autowarefoundation#616) * add as doc * pacmod_msgs -> pacmod3_msgs * fix typo * update topic names of README.md * update README.md Co-authored-by: Takayuki Murooka <[email protected]> * Auto/steering wheel status (autowarefoundation#719) * unused * add stering wheel status * fix current steer * publish turn cmd (autowarefoundation#749) * fix typo Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Takayuki Murooka <[email protected]> Co-authored-by: Takamasa Horibe <[email protected]> Co-authored-by: taikitanaka3 <[email protected]>
* fix(rclcpp): change version Signed-off-by: kosuke55 <[email protected]> * fix branch Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]>
* feat(autoware.repos): remove velodyne_vls, add nebula for LiDAR driver (autowarefoundation#632) * chore(autoware.repos): change target branch for transport_drivers from tcp to boost (autowarefoundation#637) chore(repos): update repos Signed-off-by: satoshi-ota <[email protected]> Co-authored-by: satoshi-ota <[email protected]> * feat(webauto-ci): add vehicle info params (autowarefoundation#635) * feat(webauto-ci): add vehicle info params Signed-off-by: kosuke55 <[email protected]> * fixup! feat(webauto-ci): add vehicle info params * Update .webauto-ci.yml * add comments Signed-off-by: kosuke55 <[email protected]> * add space Signed-off-by: kosuke55 <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: kosuke55 <[email protected]> Co-authored-by: kosuke55 <[email protected]> * feat(webauto-ci): traffic_light_stop_line_distance (autowarefoundation#639) feat(webauto-ci) traffic_light_stop_line_distance Signed-off-by: kosuke55 <[email protected]> * feat(webauto-ci): add walkway_stop_line_distance (autowarefoundation#641) * fix(rclcpp): change version (autowarefoundation#642) * fix(rclcpp): change version Signed-off-by: kosuke55 <[email protected]> * fix branch Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: kosuke55 <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]> Signed-off-by: kosuke55 <[email protected]> Signed-off-by: Tomohito Ando <[email protected]> Co-authored-by: David Wong <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: satoshi-ota <[email protected]> Co-authored-by: Kosuke Takeuchi <[email protected]> Co-authored-by: kosuke55 <[email protected]> Co-authored-by: Tomohito Ando <[email protected]>
Description
In #560, two new diags are added but not adde to diagnostics aggregator config.
This PR fixes it.
Related links
#560
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.