Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(topic_state_monitor): enrich error log message #7236

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

TakaHoribe
Copy link
Contributor

@TakaHoribe TakaHoribe commented Jun 3, 2024

Description

Now, there is no easy way to check why the AUTO mode is prohibited. I updated the logging message, making it easy to see the cause of the blocker of the AUTO mode transition.

Tests performed

Run with AWSIM, change topicname of traffic light, see the message will appear.

image

Effects on system behavior

The message will show up on terminal when the required topic is not published.

Interface changes

None

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TakaHoribe TakaHoribe added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 3, 2024
@TakaHoribe TakaHoribe enabled auto-merge (squash) June 3, 2024 08:49
@github-actions github-actions bot added the component:system System design and integration. (auto-assigned) label Jun 3, 2024
@TakaHoribe TakaHoribe disabled auto-merge June 19, 2024 03:29
@TakaHoribe TakaHoribe merged commit 7508103 into autowarefoundation:main Jun 19, 2024
39 of 41 checks passed
@TakaHoribe TakaHoribe deleted the enable-missing-topic-log branch June 19, 2024 03:29
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2024
TakaHoribe added a commit to tier4/autoware.universe that referenced this pull request Jun 19, 2024
chore(topic_state_monitor): enrich error log message (autowarefoundation#7236)
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:system System design and integration. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants