refactor(behavior_velocity_no_drivable_lane_module): prefix package and namespace with autoware #7469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esteve
requested review from
ahmeddesokyebrahim,
rej55,
satoshi-ota,
shmpwk,
TakaHoribe,
takayuki5168,
tkimura4,
kosuke55,
kyoichi-sugahara,
mkuri,
soblin,
maxime-clem,
taikitanaka3 and
TomohitoAndo
as code owners
esteve
added
the
tag:run-build-and-test-differential
github-actions
bot
added
type:documentation
maxime-clem
approved these changes
Jun 12, 2024
esteve
force-pushed
the
prefix-behavior_velocity_no_drivable_lane_module
branch
3 times, most recently
from
a5b594a
to
3cebd3a
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7469 +/- ##
===========================================
- Coverage 14.84% 12.46% -2.39%
===========================================
Files 1999 434 -1565
Lines 139163 36182 -102981
Branches 43716 5556 -38160
===========================================
- Hits 20661 4510 -16151
+ Misses 95731 31208 -64523
+ Partials 22771 464 -22307
☔ View full report in Codecov by Sentry. |
esteve
force-pushed
the
prefix-behavior_velocity_no_drivable_lane_module
branch
from
3cebd3a
to
b1888ff
Compare
4 tasks
…nd namespace with autoware Signed-off-by: Esteve Fernandez <[email protected]>
esteve
force-pushed
the
prefix-behavior_velocity_no_drivable_lane_module
branch
from
b1888ff
to
a6c21f1
Compare
|
@xmfcx @mitsudome-r @satoshi-ota @shmpwk could you have a look at this PR when you have a moment? Thanks. |
shmpwk
approved these changes
Jun 19, 2024
|
@shmpwk thanks! |
simon-eisenmann-driveblocks
pushed a commit
to simon-eisenmann-driveblocks/autoware.universe
that referenced
this pull request
Jun 26, 2024
…nd namespace with autoware (autowarefoundation#7469) Signed-off-by: Esteve Fernandez <[email protected]> Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan
pushed a commit
that referenced
this pull request
Jul 22, 2024
…nd namespace with autoware (#7469) Signed-off-by: Esteve Fernandez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the autoware_ prefix to the package and puts headers in the autoware namespace.
Part of:
autowarefoundation/autoware#4569
Tests performed
Not applicable.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.