Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning #7541

Merged
merged 3 commits into from
Jun 19, 2024

Conversation

veqcc
Copy link
Contributor

@veqcc veqcc commented Jun 18, 2024

Description

This is a fix based on cppcheck assignBoolToFloat warning

planning/autoware_obstacle_cruise_planner/src/node.cpp:1206:31: style: Boolean value assigned to floating point variable. [assignBoolToFloat]
  const double has_high_speed = p.crossing_obstacle_velocity_threshold <
                              ^

Tests performed

No

Effects on system behavior

No

Interface changes

No

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 18, 2024
@veqcc veqcc changed the title Fix assign bool to float warning fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning Jun 18, 2024
Copy link
Contributor

@yuki-takagi-66 yuki-takagi-66 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@veqcc veqcc added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Jun 19, 2024
Copy link

codecov bot commented Jun 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 6.54%. Comparing base (507e3f4) to head (1b7037e).
Report is 48 commits behind head on main.

Files Patch % Lines
...ning/autoware_obstacle_cruise_planner/src/node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #7541       +/-   ##
==========================================
- Coverage   14.84%   6.54%    -8.31%     
==========================================
  Files        1999     137     -1862     
  Lines      139163   14376   -124787     
  Branches    43716    2533    -41183     
==========================================
- Hits        20661     941    -19720     
+ Misses      95731   13325    -82406     
+ Partials    22771     110    -22661     
Flag Coverage Δ
differential 6.54% <0.00%> (?)
total ?

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@veqcc veqcc merged commit 1d3a094 into autowarefoundation:main Jun 19, 2024
38 of 42 checks passed
@veqcc veqcc deleted the fix_assign_bool_to_float_warning branch June 19, 2024 06:38
simon-eisenmann-driveblocks pushed a commit to simon-eisenmann-driveblocks/autoware.universe that referenced this pull request Jun 26, 2024
…utowarefoundation#7541)

* fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning

Signed-off-by: Ryuta Kambe <[email protected]>

* delete unnecessary file

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Simon Eisenmann <[email protected]>
KhalilSelyan pushed a commit that referenced this pull request Jul 22, 2024
…7541)

* fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning

Signed-off-by: Ryuta Kambe <[email protected]>

* delete unnecessary file

Signed-off-by: Ryuta Kambe <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: Ryuta Kambe <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:planning Route planning, decision-making, and navigation. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants