Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning #7541

Merged
merged 3 commits into from
Jun 19, 2024
Merged

fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning #7541

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c6e4257
fix(autoware_obstacle_cruise_planner): fix assignBoolToFloat warning
veqcc Jun 18, 2024
35f9db8
delete unnecessary file
veqcc Jun 18, 2024
1b7037e
style(pre-commit): autofix
pre-commit-ci[bot] Jun 18, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions planning/autoware_obstacle_cruise_planner/src/node.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1203,8 +1203,8 @@
// NOTE: Dynamic obstacles for stop are crossing ego's trajectory with high speed,
// and the collision between ego and obstacles are within the margin threshold.
const bool is_obstacle_crossing = isObstacleCrossing(traj_points, obstacle);
const double has_high_speed = p.crossing_obstacle_velocity_threshold <
std::hypot(obstacle.twist.linear.x, obstacle.twist.linear.y);
const bool has_high_speed = p.crossing_obstacle_velocity_threshold <
std::hypot(obstacle.twist.linear.x, obstacle.twist.linear.y);

Check warning on line 1207 in planning/autoware_obstacle_cruise_planner/src/node.cpp

View check run for this annotation

Codecov / codecov/patch

planning/autoware_obstacle_cruise_planner/src/node.cpp#L1206-L1207 

Added lines #L1206 - L1207 were not covered by tests
if (is_obstacle_crossing && has_high_speed) {
// Get highest confidence predicted path
const auto resampled_predicted_path = resampleHighestConfidencePredictedPath(
Expand Down
Loading