-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(euclidean_cluster): fix max_cluster_size bug #7734
fix(euclidean_cluster): fix max_cluster_size bug #7734
Conversation
Signed-off-by: badai-nguyen <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
I think the problem is in line 120. When adding points to the cluster, the cluster stops adding when the size of cluster is equal to |
@beginningfan Yes, I created this PR by assuming your PR#7662 is merged. It is reason I still keep it as draft. Could you merge your PR? I'm sorry for insufficient description. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7734 +/- ##
==========================================
+ Coverage 28.38% 28.39% +0.01%
==========================================
Files 1584 1585 +1
Lines 115463 115486 +23
Branches 49233 49238 +5
==========================================
+ Hits 32773 32794 +21
- Misses 73684 73695 +11
+ Partials 9006 8997 -9
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
@beginningfan I updated this PR as your PR #7662 was merged. Since you also worked on Euclidean Cluster, could I ask your review on this PR again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…7734) Signed-off-by: badai-nguyen <[email protected]>
…1378) * fix(euclidean_cluster): fix euclidean cluster params (autowarefoundation#7662) * fix(euclidean_cluster): fix max and min cluster size Signed-off-by: beginningfan <[email protected]> * fix(gnss_poser): fix a typo Signed-off-by: beginningfan <[email protected]> * fix(euclidean_cluster): fix min cluster size Signed-off-by: beginningfan <[email protected]> * style(pre-commit): autofix --------- Signed-off-by: beginningfan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> * fix(euclidean_cluster): fix max_cluster_size bug (autowarefoundation#7734) Signed-off-by: badai-nguyen <[email protected]> * fix(ground_segmentation): fix bug (autowarefoundation#7771) --------- Signed-off-by: beginningfan <[email protected]> Signed-off-by: badai-nguyen <[email protected]> Co-authored-by: beginningfan <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <[email protected]>
…7734) Signed-off-by: badai-nguyen <[email protected]> Signed-off-by: palas21 <[email protected]>
…7734) Signed-off-by: badai-nguyen <[email protected]>
Signed-off-by: badai-nguyen <[email protected]>
…7734) Signed-off-by: badai-nguyen <[email protected]>
Description
To fix the bug of processing the cluster related to `max_cluster_size:
max_cluster_size
is still clutered with firstmax_cluster_size
copying points.max_cluster_size = 100
but part of car still clustered.Releated PR: fix(euclidean_cluster): add intensity field #6818
This PR will open for review after fix(euclidean_cluster): fix euclidean cluster params #7662 is merged.
Related links
How was this PR tested?
max_cluster_size
) will not be clustered.max_cluster_size = 100
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.