Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(euclidean_cluster, ground_segmentation): cherry-pick bug fix PRs #1378

Merged
merged 3 commits into from
Jul 4, 2024

Conversation

badai-nguyen
Copy link

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Interface changes

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

beginningfan and others added 2 commits July 3, 2024 13:40
…ion#7662)

* fix(euclidean_cluster): fix max and min cluster size

Signed-off-by: beginningfan <[email protected]>

* fix(gnss_poser): fix a typo

Signed-off-by: beginningfan <[email protected]>

* fix(euclidean_cluster): fix min cluster size

Signed-off-by: beginningfan <[email protected]>

* style(pre-commit): autofix

---------

Signed-off-by: beginningfan <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Copy link

sonarcloud bot commented Jul 3, 2024

@badai-nguyen
Copy link
Author

@YoshiRi @yukkysaito Could you approve this cherry-pick PR for v0.29.0?

Copy link

@YoshiRi YoshiRi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen merged commit a28bbd2 into beta/v0.29.0 Jul 4, 2024
21 of 22 checks passed
@badai-nguyen badai-nguyen deleted the fix/euclidean_cluster_max_cluster_size branch July 4, 2024 01:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants