feat(simple_planning_simulator): add VGR sim model #8415
Merged
CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (main)
failed
Aug 20, 2024 in 49s
CodeScene PR Check
❌ Code Health Quality Gates: FAILED
Change in average Code Health of affected files: -0.26 (8.12 -> 7.85)
- Declining Code Health: 9 findings(s) 🚩
Details
🚩 Declining Code Health (highest to lowest):
- Large Method simple_planning_simulator_core.cpp: SimplePlanningSimulator::SimplePlanningSimulator
- Large Method test_simple_planning_simulator.cpp: TEST_P
- Large Method simple_planning_simulator.launch.py: launch_setup
- Complex Conditional sim_model_actuation_cmd.cpp: SimModelActuationCmd::getActuationStatus
- Complex Method simple_planning_simulator_core.cpp: SimplePlanningSimulator::initialize_vehicle_model
- Bumpy Road Ahead simple_planning_simulator_core.cpp: SimplePlanningSimulator::initialize_vehicle_model
- Bumpy Road Ahead sim_model_actuation_cmd.cpp: SimModelActuationCmd::getActuationStatus
- Complex Method sim_model_actuation_cmd.cpp: SimModelActuationCmd::calcModel
- Complex Method sim_model_actuation_cmd.cpp: SimModelActuationCmd::getActuationStatus
Annotations
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
launch_setup increases from 91 to 92 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
SimplePlanningSimulator::initialize_vehicle_model increases in cyclomatic complexity from 14 to 18, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
SimplePlanningSimulator::SimplePlanningSimulator increases from 104 to 109 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
SimplePlanningSimulator::initialize_vehicle_model has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Complex Method
SimModelActuationCmd::calcModel increases in cyclomatic complexity from 11 to 13, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Method
SimModelActuationCmd::getActuationStatus has a cyclomatic complexity of 9, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Complex Conditional
SimModelActuationCmd::getActuationStatus has 1 complex conditionals with 2 branches, threshold = 2. A complex conditional is an expression inside a branch (e.g. if, for, while) which consists of multiple, logical operators such as AND/OR. The more logical operators in an expression, the more severe the code smell.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ New issue: Bumpy Road Ahead
SimModelActuationCmd::getActuationStatus has 2 blocks with nested conditional logic. Any nesting of 2 or deeper is considered. Threshold is one single, nested block per function. The Bumpy Road code smell is a function that contains multiple chunks of nested conditional logic. The deeper the nesting and the more bumps, the lower the code health.
codescene-delta-analysis / CodeScene Cloud Delta Analysis (main)
❌ Getting worse: Large Method
TEST_P increases from 80 to 95 lines of code, threshold = 70. Large functions with many lines of code are generally harder to understand and lower the code health. Avoid adding more lines to this function.
Loading