fix(autoware_map_based_prediction): use surrounding_crosswalks instead of external_surrounding_crosswalks #8467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhisaki
requested review from
ktro2828,
kyoichi-sugahara,
takayuki5168,
tkimura4 and
YoshiRi
as code owners
github-actions
bot
added
the
component:perception
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
the
tag:run-build-and-test-differential
soblin
approved these changes
Aug 14, 2024
yuki-takagi-66
approved these changes
Aug 14, 2024
perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp
Show resolved
Hide resolved
…d of external_surrounding_crosswalks Signed-off-by: Y.Hisaki <[email protected]>
yhisaki
force-pushed
the
fix-bug-of-map_based_prediction
branch
from
67eb10a
to
ba0b685
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8467 +/- ##
==========================================
- Coverage 23.91% 23.89% -0.02%
==========================================
Files 1380 1382 +2
Lines 101739 101770 +31
Branches 38716 38721 +5
==========================================
- Hits 24329 24322 -7
- Misses 74930 74968 +38
Partials 2480 2480
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
YoshiRi
approved these changes
Aug 14, 2024
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 15, 2024
…d of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Y.Hisaki <[email protected]>
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 15, 2024
…d of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Y.Hisaki <[email protected]>
technolojin
pushed a commit
to technolojin/autoware.universe
that referenced
this pull request
Aug 15, 2024
…d of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Yukinari Hisaki <[email protected]>
technolojin
added a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…performance of map_based_prediction (#1464) * fix(autoware_map_based_prediction): fix argument order (autowarefoundation#8031) fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()` Signed-off-by: yucedagonurcan <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]> * perf(map_based_prediction): remove unncessary withinRoadLanelet() (autowarefoundation#8403) Signed-off-by: Mamoru Sobue <[email protected]> * perf(map_based_prediction): create a fence LineString layer and use rtree query (autowarefoundation#8406) use fence layer Signed-off-by: Mamoru Sobue <[email protected]> * perf(map_based_prediction): apply lerp instead of spline (autowarefoundation#8416) perf: apply lerp interpolation instead of spline Signed-off-by: Kotaro Uetake <[email protected]> * perf(autoware_map_based_prediction): improve orientation calculation and resample converted path (autowarefoundation#8427) * refactor: improve orientation calculation and resample converted path with linear interpolation Simplify the calculation of the orientation for each pose in the convertPathType function by directly calculating the sine and cosine of half the yaw angle. This improves efficiency and readability. Also, improve the resampling of the converted path by using linear interpolation for better performance. Signed-off-by: Taekjin LEE <[email protected]> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <[email protected]> * Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp Co-authored-by: Kotaro Uetake <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]> * perf(map_based_prediction): improve world to map transform calculation (autowarefoundation#8413) * perf(map_based_prediction): improve world to map transform calculation 1. remove unused transforms 2. make transform loading late as possible Signed-off-by: Taekjin LEE <[email protected]> * perf(map_based_prediction): get transform only when it is necessary Signed-off-by: Taekjin LEE <[email protected]> --------- Signed-off-by: Taekjin LEE <[email protected]> * feat(autoware_universe_utils): add LRU Cache (autowarefoundation#8456) Signed-off-by: Yukinari Hisaki <[email protected]> * perf(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType (autowarefoundation#8461) feat(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType Signed-off-by: Yukinari Hisaki <[email protected]> * fix(autoware_map_based_prediction): use surrounding_crosswalks instead of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Yukinari Hisaki <[email protected]> --------- Signed-off-by: Mamoru Sobue <[email protected]> Signed-off-by: Kotaro Uetake <[email protected]> Signed-off-by: Taekjin LEE <[email protected]> Signed-off-by: Yukinari Hisaki <[email protected]> Co-authored-by: Onur Can Yücedağ <[email protected]> Co-authored-by: Shintaro Tomie <[email protected]> Co-authored-by: Kotaro Uetake <[email protected]> Co-authored-by: Mamoru Sobue <[email protected]> Co-authored-by: Shumpei Wakabayashi <[email protected]> Co-authored-by: Yukinari Hisaki <[email protected]>
xtk8532704
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Aug 15, 2024
…d of external_surrounding_crosswalks (autowarefoundation#8467) Signed-off-by: Y.Hisaki <[email protected]> Signed-off-by: xtk8532704 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix bug in autoware_map_based_prediction. Details are described in internal slack.
Related links
Parent Issue:
How was this PR tested?
Tested on psim.
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.