Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(map_based_prediction): create a fence LineString layer and use rtree query #8406

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 8, 2024

Description

instead of searching from all LineStrings, create an articulated fence layer

Related links

https://star4.slack.com/archives/C03S84LDJGG/p1723084187292029

How was this PR tested?

worst processing time for a rosbag changed from

  • 21.59ms, 23.53ms, 26.68ms

to

  • 21.86ms, 22.16ms, 23.39ms

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

Signed-off-by: Mamoru Sobue <[email protected]>
@github-actions github-actions bot added the component:perception Advanced sensor data processing and environment understanding. (auto-assigned) label Aug 8, 2024
Copy link

github-actions bot commented Aug 8, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@soblin soblin added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 8, 2024
@soblin soblin enabled auto-merge (squash) August 8, 2024 09:36
Copy link

codecov bot commented Aug 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 23.73%. Comparing base (022bd17) to head (3abd025).
Report is 12 commits behind head on main.

Files Patch % Lines
...based_prediction/src/map_based_prediction_node.cpp 0.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8406      +/-   ##
==========================================
- Coverage   23.74%   23.73%   -0.02%     
==========================================
  Files        1378     1380       +2     
  Lines      101354   101382      +28     
  Branches    38522    38521       -1     
==========================================
- Hits        24068    24062       -6     
- Misses      74870    74904      +34     
  Partials     2416     2416              
Flag Coverage Δ *Carryforward flag
differential 2.14% <0.00%> (?)
total 23.74% <ø> (-0.01%) ⬇️ Carriedforward from 022bd17

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@soblin soblin merged commit a5d77b4 into autowarefoundation:main Aug 8, 2024
38 of 39 checks passed
@soblin soblin deleted the perf/map-based-prediction/fence-layer branch August 8, 2024 11:20
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Aug 9, 2024
esteve pushed a commit to esteve/autoware.universe that referenced this pull request Aug 13, 2024
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 15, 2024
technolojin pushed a commit to technolojin/autoware.universe that referenced this pull request Aug 15, 2024
technolojin added a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…performance of map_based_prediction (#1464)

* fix(autoware_map_based_prediction): fix argument order (autowarefoundation#8031)

fix(autoware_map_based_prediction): fix argument order in call `getFrenetPoint()`

Signed-off-by: yucedagonurcan <[email protected]>

Co-authored-by: Shintaro Tomie <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>

* perf(map_based_prediction): remove unncessary withinRoadLanelet() (autowarefoundation#8403)

Signed-off-by: Mamoru Sobue <[email protected]>

* perf(map_based_prediction): create a fence LineString layer and use rtree query (autowarefoundation#8406)

use fence layer

Signed-off-by: Mamoru Sobue <[email protected]>

* perf(map_based_prediction): apply lerp instead of spline (autowarefoundation#8416)

perf: apply lerp interpolation instead of spline

Signed-off-by: Kotaro Uetake <[email protected]>

* perf(autoware_map_based_prediction): improve orientation calculation and resample converted path (autowarefoundation#8427)

* refactor: improve orientation calculation and resample converted path with linear interpolation

Simplify the calculation of the orientation for each pose in the convertPathType function by directly calculating the sine and cosine of half the yaw angle. This improves efficiency and readability. Also, improve the resampling of the converted path by using linear interpolation for better performance.

Signed-off-by: Taekjin LEE <[email protected]>

* Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Kotaro Uetake <[email protected]>

* Update perception/autoware_map_based_prediction/src/map_based_prediction_node.cpp

Co-authored-by: Kotaro Uetake <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>

* perf(map_based_prediction): improve world to map transform calculation (autowarefoundation#8413)

* perf(map_based_prediction): improve world to map transform calculation

1. remove unused transforms
2. make transform loading late as possible

Signed-off-by: Taekjin LEE <[email protected]>

* perf(map_based_prediction): get transform only when it is necessary

Signed-off-by: Taekjin LEE <[email protected]>

---------

Signed-off-by: Taekjin LEE <[email protected]>

* feat(autoware_universe_utils): add LRU Cache (autowarefoundation#8456)

Signed-off-by: Yukinari Hisaki <[email protected]>

* perf(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType (autowarefoundation#8461)

feat(autoware_map_based_prediction): speed up map based prediction by using lru cache in convertPathType

Signed-off-by: Yukinari Hisaki <[email protected]>

* fix(autoware_map_based_prediction): use surrounding_crosswalks instead of external_surrounding_crosswalks (autowarefoundation#8467)

Signed-off-by: Yukinari Hisaki <[email protected]>

---------

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: Kotaro Uetake <[email protected]>
Signed-off-by: Taekjin LEE <[email protected]>
Signed-off-by: Yukinari Hisaki <[email protected]>
Co-authored-by: Onur Can Yücedağ <[email protected]>
Co-authored-by: Shintaro Tomie <[email protected]>
Co-authored-by: Kotaro Uetake <[email protected]>
Co-authored-by: Mamoru Sobue <[email protected]>
Co-authored-by: Shumpei Wakabayashi <[email protected]>
Co-authored-by: Yukinari Hisaki <[email protected]>
xtk8532704 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 15, 2024
…tree query (autowarefoundation#8406)

use fence layer

Signed-off-by: Mamoru Sobue <[email protected]>
Signed-off-by: xtk8532704 <[email protected]>
technolojin added a commit to technolojin/autoware.universe that referenced this pull request Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:perception Advanced sensor data processing and environment understanding. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants