refactor(autoware_pointcloud_preprocessor): rework ring outlier filter parameters

[vividf]

Description

Description

This PR includes the following changes

1. Remove the default parameters for the ring outlier filter node.
2. Add parameter, launch file, and parameters schema for the node.
3. Change the name nodelet to node.

A big thank you to @Ariiees for the PRs (#8297 and #7422), where we worked together on the entire pointcloud preprocessor parameters, launch file, and schema.

Note that the schema for filter.param.yaml will be implemented in another PR.

Related links

Parent Issue:

• Link

How was this PR tested?

ros2 launch autoware_pointcloud_preprocessor ring_outlier_filter_node.launch.xml

Notes for reviewers

Need to merge together with
tier4/aip_launcher#305
autowarefoundation/sample_sensor_kit_launch#103

Interface changes

None.

Effects on system behavior

None.

[github-actions]

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

• You've checked our contribution guidelines.
• Your PR follows our pull request guidelines.
• All required CI checks pass before marking the PR ready for review.

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes missing coverage. Please review.

Project coverage is 23.92%. Comparing base (1bf24e4) to head (9b6614c).
Report is 71 commits behind head on main.

Files with missing lines	Patch %	Lines
...or/src/outlier_filter/ring_outlier_filter_node.cpp	0.00%	12 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #8468      +/-   ##
==========================================
- Coverage   27.99%   23.92%   -4.07%     
==========================================
  Files        1319     1416      +97     
  Lines       98732   103181    +4449     
  Branches    39798    39518     -280     
==========================================
- Hits        27637    24683    -2954     
- Misses      70972    75868    +4896     
- Partials      123     2630    +2507     

Flag	Coverage Δ		*Carryforward flag
differential	19.11% <0.00%> (?)
total	24.12% <ø> (-3.87%)	⬇️	Carriedforward from 1a1ecf9

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[github-actions]

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8468/
Modified URLs:

• https://autowarefoundation.github.io/autoware.universe/pr-8468/sensing/autoware_pointcloud_preprocessor/ring-outlier-filter/

[knzo25]

Left some comments (please check those that apply to the other PRs in this series of parameter related PRs)

[vividf]

PRs that need an additional cast for variables:

1. refactor(autoware_pointcloud_preprocessor): rework pointcloud accumulator parameters  #8487
2. refactor(autoware_pointcloud_preprocessor): rework random downsample filter parameters #8485
3. refactor(autoware_pointcloud_preprocessor): rework radius search 2d outlier filter parameters #8474
4. refactor(autoware_pointcloud_preprocessor): rework filter parameters  #8469
5. refactor(autoware_pointcloud_preprocessor): rework ring outlier filter parameters #8468

[vividf]

Note: need to merge together with the PR autowarefoundation/sample_sensor_kit_launch#103

[badai-nguyen]

@vividf Could you also update the parameters for RingOutlierFilterComponent in aip_launcher

[vividf]

@badai-nguyen Sure, I will update it as well.

[knzo25]

@vividf
Remember to paste links of related PRs (like the one dai-san asked you). It is important to keep track as just pasting the link adds an event in the timeline of both PRs

[vividf]

Note: this PR should be merged together with

1. feat(aip_launcher): ring outlier filter node load from param file tier4/aip_launcher#305
2. feat(common_sensor_launch): ring outlier filter load from param file sample_sensor_kit_launch#103

[knzo25]

See the previous comment. Just checked and this applies in several places of this PR. Check other PRs and also the ones of this series that you already merged

[knzo25]

LGTM