Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(single_lidar_common_launch): load from parameter #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

@vividf
Copy link
Author

vividf commented Oct 22, 2024

@mojomex @beginningfan could you review this, thanks

@beginningfan
Copy link
Collaborator

beginningfan commented Oct 25, 2024

@vividf Thanks for your work. LGTM.
Actually, when I created this repository, I had a lot of confusion about the config of sensor_kit and individual_marams. At that time, I directly used the config of sensor_kit. However, now autoware.launch.xml has always been individual_marams. If it continues to be individual_marams, we also need to add a default config of single_lidar_sensor_kit in the autoware_individual_params repository to launch single_lidar_sensor_kit successfully. Can you please complete this task?

@cyn-liu
Copy link

cyn-liu commented Oct 25, 2024

@vividf Thanks for your work. LGTM.
I will review this PR later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants