Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filter parameters #8491

Merged
merged 7 commits into from
Aug 22, 2024
Merged

refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filter parameters #8491

merged 7 commits into from
Aug 22, 2024

Conversation

vividf
Copy link
Contributor

@vividf vividf commented Aug 15, 2024

Description

This PR includes the following changes

  1. Remove the default parameters for the lanelet2 map filter node.
  2. Add parameter, launch file, and parameters schema for the node.
  3. Change the name nodelet to node.

Related links

Parent Issue:

  • Link

How was this PR tested?

ros2 launch autoware_pointcloud_preprocessor lanelet2_map_filter_node.launch.xml

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added type:documentation Creating or refining documentation. (auto-assigned) component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) labels Aug 15, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 15, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@vividf vividf self-assigned this Aug 15, 2024
@vividf vividf added tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) labels Aug 15, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 15, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 23.78%. Comparing base (b247c43) to head (f229946).
Report is 4 commits behind head on main.

Files Patch % Lines
...src/vector_map_filter/lanelet2_map_filter_node.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #8491      +/-   ##
==========================================
- Coverage   23.99%   23.78%   -0.22%     
==========================================
  Files        1384     1390       +6     
  Lines      102173   102124      -49     
  Branches    38956    38989      +33     
==========================================
- Hits        24520    24291     -229     
- Misses      75180    75355     +175     
- Partials     2473     2478       +5
Flag Coverage Δ *Carryforward flag
differential 19.08% <0.00%> (?)
total 24.00% <ø> (+0.01%) ⬆️ Carriedforward from 8b57823

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

knzo25
knzo25 approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@knzo25 knzo25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

amadeuszsz
amadeuszsz requested changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please consider boundaries for numeric / integer parameters. This comment apply for rest of pointcloud preprocessor PRs as well

@vividf
Copy link
Contributor Author

vividf commented Aug 20, 2024 •
edited
Loading

@amadeuszsz Thanks, added in 8b57823

@github-actions GitHub Actions
Copy link

Documentation URL: https://autowarefoundation.github.io/autoware.universe/pr-8491/
Modified URLs:

@vividf vividf requested a review from amadeuszsz August 20, 2024 10:07
amadeuszsz
amadeuszsz approved these changes Aug 21, 2024
View reviewed changes
Copy link
Contributor

@amadeuszsz amadeuszsz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vividf vividf enabled auto-merge (squash) August 22, 2024 08:37
@vividf vividf merged commit 44e0535 into autowarefoundation:main Aug 22, 2024
25 checks passed
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
@vividf @kyoichi-sugahara
refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filte…
8b23f9a 
…r parameters (autowarefoundation#8491)

* feat: rework lanelet2 map filter parameters

Signed-off-by: vividf <[email protected]>

* chore: remove unrelated files

Signed-off-by: vividf <[email protected]>

* fix: fix node name in launch

Signed-off-by: vividf <[email protected]>

* chore: fix launcher

Signed-off-by: vividf <[email protected]>

* chore: fix spell error

Signed-off-by: vividf <[email protected]>

* chore: add boundary

Signed-off-by: vividf <[email protected]>

---------

Signed-off-by: vividf <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
@vividf @a-maumau
refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filte…
bfadfae 
…r parameters (autowarefoundation#8491)

* feat: rework lanelet2 map filter parameters

Signed-off-by: vividf <[email protected]>

* chore: remove unrelated files

Signed-off-by: vividf <[email protected]>

* fix: fix node name in launch

Signed-off-by: vividf <[email protected]>

* chore: fix launcher

Signed-off-by: vividf <[email protected]>

* chore: fix spell error

Signed-off-by: vividf <[email protected]>

* chore: add boundary

Signed-off-by: vividf <[email protected]>

---------

Signed-off-by: vividf <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@knzo25 knzo25 knzo25 approved these changes

@amadeuszsz amadeuszsz amadeuszsz approved these changes

@amc-nu amc-nu Awaiting requested review from amc-nu amc-nu is a code owner

@badai-nguyen badai-nguyen Awaiting requested review from badai-nguyen badai-nguyen is a code owner

@drwnz drwnz Awaiting requested review from drwnz drwnz is a code owner

@kyoichi-sugahara kyoichi-sugahara Awaiting requested review from kyoichi-sugahara kyoichi-sugahara is a code owner

@meliketanrikulu meliketanrikulu Awaiting requested review from meliketanrikulu meliketanrikulu is a code owner

@miursh miursh Awaiting requested review from miursh miursh is a code owner

@YoshiRi YoshiRi Awaiting requested review from YoshiRi YoshiRi is a code owner

@yukkysaito yukkysaito Awaiting requested review from yukkysaito yukkysaito is a code owner

Assignees

@vividf vividf

Labels
component:sensing Data acquisition from sensors, drivers, preprocessing. (auto-assigned) tag:deploy-docs Mark for deploy-docs action generation. (used-by-ci) tag:require-cuda-build-and-test tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:documentation Creating or refining documentation. (auto-assigned)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vividf @knzo25 @amadeuszsz