-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filter parameters #8491
refactor(autoware_pointcloud_preprocessor): rework lanelet2 map filter parameters #8491
Conversation
Signed-off-by: vividf <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8491 +/- ##
==========================================
- Coverage 23.99% 23.78% -0.22%
==========================================
Files 1384 1390 +6
Lines 102173 102124 -49
Branches 38956 38989 +33
==========================================
- Hits 24520 24291 -229
- Misses 75180 75355 +175
- Partials 2473 2478 +5
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider boundaries for numeric / integer parameters. This comment apply for rest of pointcloud preprocessor PRs as well
Signed-off-by: vividf <[email protected]>
Signed-off-by: vividf <[email protected]>
@amadeuszsz Thanks, added in 8b57823 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…r parameters (autowarefoundation#8491) * feat: rework lanelet2 map filter parameters Signed-off-by: vividf <[email protected]> * chore: remove unrelated files Signed-off-by: vividf <[email protected]> * fix: fix node name in launch Signed-off-by: vividf <[email protected]> * chore: fix launcher Signed-off-by: vividf <[email protected]> * chore: fix spell error Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
…r parameters (autowarefoundation#8491) * feat: rework lanelet2 map filter parameters Signed-off-by: vividf <[email protected]> * chore: remove unrelated files Signed-off-by: vividf <[email protected]> * fix: fix node name in launch Signed-off-by: vividf <[email protected]> * chore: fix launcher Signed-off-by: vividf <[email protected]> * chore: fix spell error Signed-off-by: vividf <[email protected]> * chore: add boundary Signed-off-by: vividf <[email protected]> --------- Signed-off-by: vividf <[email protected]>
Description
This PR includes the following changes
nodelet
tonode
.Related links
Parent Issue:
How was this PR tested?
ros2 launch autoware_pointcloud_preprocessor lanelet2_map_filter_node.launch.xml
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.