Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vehicle_cmd_gate): delete deprecated parameters #8537

Conversation

Autumn60
Copy link
Contributor

@Autumn60 Autumn60 commented Aug 20, 2024

Description

Delete deprecated parameters in vehicle_cmd_gate.param.yaml

The following parameters have been removed as they are no longer used by vehicle_cmd_gate node.

  • use_start_request
  • stopped_state_entry_duration_time

Related links

None.

How was this PR tested?

PSim test was performed.

Notes for reviewers

PR for autoware_launch:
autowarefoundation/autoware_launch#1127

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the component:control Vehicle control algorithms and mechanisms. (auto-assigned) label Aug 20, 2024
Copy link

github-actions bot commented Aug 20, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@Autumn60 Autumn60 added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 21, 2024
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 23.94%. Comparing base (774f67f) to head (8caa2b2).
Report is 30 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8537      +/-   ##
==========================================
+ Coverage   23.91%   23.94%   +0.03%     
==========================================
  Files        1382     1385       +3     
  Lines      101974   101791     -183     
  Branches    38831    38701     -130     
==========================================
- Hits        24384    24371      -13     
+ Misses      75123    74978     -145     
+ Partials     2467     2442      -25     
Flag Coverage Δ *Carryforward flag
differential 12.01% <ø> (?)
total 23.94% <ø> (+0.02%) ⬆️ Carriedforward from d4a0443

*This pull request uses carry forward flags. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Autumn60 Autumn60 merged commit f787f55 into autowarefoundation:main Aug 22, 2024
39 checks passed
@Autumn60 Autumn60 deleted the chore/vehicle_cmd_gate/delete_deprecated_params branch August 22, 2024 07:17
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…tion#8537)

delete deprecated params in vehicle_cmd_gate.param.yaml

Signed-off-by: Autumn60 <[email protected]>
a-maumau pushed a commit to a-maumau/autoware.universe that referenced this pull request Sep 2, 2024
…tion#8537)

delete deprecated params in vehicle_cmd_gate.param.yaml

Signed-off-by: Autumn60 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:control Vehicle control algorithms and mechanisms. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants