-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(build-and-test-differential): skip cuda build when tag:require-cuda-build-and-test is not attached #8562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
label
Aug 21, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
yhisaki
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 21, 2024
Is this still draft PR? |
…uda-build-and-test is not attached Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
yhisaki
force-pushed
the
ci/skip-cuda-build
branch
from
August 22, 2024 00:31
c8f492b
to
42332ec
Compare
@youtalk |
youtalk
reviewed
Aug 22, 2024
youtalk
approved these changes
Aug 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…uda-build-and-test is not attached (autowarefoundation#8562) * feat(build-and-test-differential): skip cuda build when tag:require-cuda-build-and-test is not attached Signed-off-by: Y.Hisaki <[email protected]> * fix miss Signed-off-by: Y.Hisaki <[email protected]> * for debugging Signed-off-by: Y.Hisaki <[email protected]> * fix bug Signed-off-by: Y.Hisaki <[email protected]> * remove debug code Signed-off-by: Y.Hisaki <[email protected]> --------- Signed-off-by: Y.Hisaki <[email protected]>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
type:ci
Continuous Integration (CI) processes and testing. (auto-assigned)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR is to prevent the execution of build-and-test-differential (humble, -cuda) for PRs related to packages that are not cuda-related.
For PRs that do not have the tag:require-cuda-build-and-test label, all steps within build-and-test-differential (humble, -cuda) will be skipped.
Related links
This PR reflects the advice of #8547.
How was this PR tested?
The setting of this action works well in https://github.com/autowarefoundation/autoware.universe/actions/runs/10488733741/job/29051839562?pr=8562.
Notes for reviewers
This PR should be merged after #8555 is merged.
Interface changes
None.
Effects on system behavior
None.