Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(build-and-test-differential): skip cuda build when tag:require-cuda-build-and-test is not attached #8562

Merged
merged 5 commits into from
Aug 22, 2024

Conversation

yhisaki
Copy link
Contributor

@yhisaki yhisaki commented Aug 21, 2024

Description

This PR is to prevent the execution of build-and-test-differential (humble, -cuda) for PRs related to packages that are not cuda-related.

For PRs that do not have the tag:require-cuda-build-and-test label, all steps within build-and-test-differential (humble, -cuda) will be skipped.

Related links

This PR reflects the advice of #8547.

How was this PR tested?

The setting of this action works well in https://github.com/autowarefoundation/autoware.universe/actions/runs/10488733741/job/29051839562?pr=8562.

Notes for reviewers

This PR should be merged after #8555 is merged.

Interface changes

None.

Effects on system behavior

None.

@github-actions github-actions bot added the type:ci Continuous Integration (CI) processes and testing. (auto-assigned) label Aug 21, 2024
Copy link

github-actions bot commented Aug 21, 2024

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@yhisaki yhisaki marked this pull request as draft August 21, 2024 10:05
@yhisaki yhisaki added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 21, 2024
@youtalk
Copy link
Member

youtalk commented Aug 21, 2024

Is this still draft PR?

…uda-build-and-test is not attached

Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
Signed-off-by: Y.Hisaki <[email protected]>
@yhisaki yhisaki marked this pull request as ready for review August 22, 2024 00:36
@yhisaki
Copy link
Contributor Author

yhisaki commented Aug 22, 2024

@youtalk
PR is now open! Please review!

Copy link
Member

@youtalk youtalk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yhisaki yhisaki merged commit ecc9586 into autowarefoundation:main Aug 22, 2024
24 of 25 checks passed
@yhisaki yhisaki deleted the ci/skip-cuda-build branch August 22, 2024 05:42
kyoichi-sugahara pushed a commit to kyoichi-sugahara/autoware.universe that referenced this pull request Aug 27, 2024
…uda-build-and-test is not attached (autowarefoundation#8562)

* feat(build-and-test-differential): skip cuda build when tag:require-cuda-build-and-test is not attached

Signed-off-by: Y.Hisaki <[email protected]>

* fix miss

Signed-off-by: Y.Hisaki <[email protected]>

* for debugging

Signed-off-by: Y.Hisaki <[email protected]>

* fix bug

Signed-off-by: Y.Hisaki <[email protected]>

* remove debug code

Signed-off-by: Y.Hisaki <[email protected]>

---------

Signed-off-by: Y.Hisaki <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) type:ci Continuous Integration (CI) processes and testing. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants