feat(raw_vehicle_cmd_converter): disable actuation to steering #8588
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kosuke55 <[email protected]>
kosuke55
requested review from
mkuri,
zusizusi,
taikitanaka3 and
TakaHoribe
as code owners
github-actions
bot
added
the
component:vehicle
|
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
kosuke55
added
the
tag:run-build-and-test-differential
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8588 +/- ##
==========================================
- Coverage 24.02% 24.01% -0.01%
==========================================
Files 1384 1385 +1
Lines 102177 102202 +25
Branches 38956 38957 +1
==========================================
Hits 24544 24544
- Misses 75138 75163 +25
Partials 2495 2495
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
TakaHoribe
reviewed
Aug 23, 2024
TakaHoribe
approved these changes
Aug 23, 2024
kyoichi-sugahara
pushed a commit
to kyoichi-sugahara/autoware.universe
that referenced
this pull request
Aug 27, 2024
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
a-maumau
pushed a commit
to a-maumau/autoware.universe
that referenced
this pull request
Sep 2, 2024
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
same reason to autowarefoundation/autoware_launch#1132
disable actuation to steering by defalut.
this is new feature introduced in #8504
but many user don't kwnow the details.
In practice, the description config is called, and this launcher config is often not used, but for now it defaults to false.
Related links
Parent Issue:
How was this PR tested?
this config in universe is just example not affect the behavior
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.