-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(raw_vehicle_cmd_converter): disable actuation to steering #8588
feat(raw_vehicle_cmd_converter): disable actuation to steering #8588
Conversation
Signed-off-by: kosuke55 <[email protected]>
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8588 +/- ##
==========================================
- Coverage 24.02% 24.01% -0.01%
==========================================
Files 1384 1385 +1
Lines 102177 102202 +25
Branches 38956 38957 +1
==========================================
Hits 24544 24544
- Misses 75138 75163 +25
Partials 2495 2495
*This pull request uses carry forward flags. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is recently introduced, and not used anywhere yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is recently introduced, and not used anywhere yet.
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
…arefoundation#8588) Signed-off-by: kosuke55 <[email protected]>
Description
same reason to autowarefoundation/autoware_launch#1132
disable actuation to steering by defalut.
this is new feature introduced in #8504
but many user don't kwnow the details.
In practice, the description config is called, and this launcher config is often not used, but for now it defaults to false.
Related links
Parent Issue:
How was this PR tested?
this config in universe is just example not affect the behavior
Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
None.