-
Notifications
You must be signed in to change notification settings - Fork 640
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(stop_filter): extract stop_filter.param.yaml to autoware_launch #8681
Merged
TaikiYamada4
merged 2 commits into
autowarefoundation:main
from
TaikiYamada4:chore/localization/stop_filter/export_param_file_to_launch
Aug 30, 2024
Merged
chore(stop_filter): extract stop_filter.param.yaml to autoware_launch #8681
TaikiYamada4
merged 2 commits into
autowarefoundation:main
from
TaikiYamada4:chore/localization/stop_filter/export_param_file_to_launch
Aug 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: TaikiYamada4 <[email protected]>
github-actions
bot
added
the
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
label
Aug 30, 2024
Thank you for contributing to the Autoware project! 🚧 If your pull request is in progress, switch it to draft mode. Please ensure:
|
4 tasks
TaikiYamada4
requested review from
anhnv3991,
KYabuuchi,
Motsu-san,
RyuYamamoto,
SakodaShintaro and
YamatoAndo
as code owners
August 30, 2024 02:35
SakodaShintaro
added
the
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
label
Aug 30, 2024
SakodaShintaro
approved these changes
Aug 30, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I ran the Evaluator tests (TIER IV INTERNAL LINK), and all the tests passed.
LGTM
TaikiYamada4
deleted the
chore/localization/stop_filter/export_param_file_to_launch
branch
August 30, 2024 07:55
ktro2828
pushed a commit
to ktro2828/autoware.universe
that referenced
this pull request
Sep 18, 2024
…autowarefoundation#8681) Extract stop_filter.param.yaml to autoware_launch Signed-off-by: TaikiYamada4 <[email protected]>
h-ohta
pushed a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 17, 2024
…autowarefoundation#8681) Extract stop_filter.param.yaml to autoware_launch Signed-off-by: TaikiYamada4 <[email protected]>
This was referenced Oct 21, 2024
h-ohta
added a commit
to tier4/autoware.universe
that referenced
this pull request
Oct 23, 2024
…autowarefoundation#8681) (#1591) Co-authored-by: TaikiYamada4 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component:launch
Launch files, scripts and initialization tools. (auto-assigned)
tag:run-build-and-test-differential
Mark to enable build-and-test-differential workflow. (used-by-ci)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable to set the
param_path
ofstop filter.param.yaml
.Especially expected to get from autoware_launch.
Related links
This PR has to work and be merged with autowarefoundation/autoware_launch#1145 together.
How was this PR tested?
ros2 param dump /localization/pose_twist_fusion_filter/stop_filter
return the following. When I changedvx_threshold
to 1.1.twist.x
of/localization/kinematic_state
changes when I change the parameter in autoware_launch.Notes for reviewers
None.
Interface changes
None.
Effects on system behavior
stop_filter
will get parameters fromstop_filter.param.yaml
in autoware_launch