Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(stop_filter): extract stop_filter.param.yaml to autoware_launch #8681

Merged
merged 2 commits into from
Aug 30, 2024
Merged

chore(stop_filter): extract stop_filter.param.yaml to autoware_launch #8681

merged 2 commits into from
Aug 30, 2024

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 30, 2024 •
edited
Loading

Description

Enable to set the param_path of stop filter.param.yaml.
Especially expected to get from autoware_launch.

Related links

This PR has to work and be merged with autowarefoundation/autoware_launch#1145 together.

How was this PR tested?

  1. Checked that rosbag replay tutorial works.
  2. Checked that ros2 param dump /localization/pose_twist_fusion_filter/stop_filter return the following. When I changed vx_threshold to 1.1.
/localization/pose_twist_fusion_filter/stop_filter:
  ros__parameters:
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
    use_sim_time: true
    vx_threshold: 1.1
    wz_threshold: 0.02
  1. Confirmed that minimum twist.x of /localization/kinematic_state changes when I change the parameter in autoware_launch.

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

stop_filter will get parameters from stop_filter.param.yaml in autoware_launch

@github-actions github-actions bot added the component:launch Launch files, scripts and initialization tools. (auto-assigned) label Aug 30, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 30, 2024 •
edited
Loading

Thank you for contributing to the Autoware project!

🚧 If your pull request is in progress, switch it to draft mode.

Please ensure:

@TaikiYamada4 TaikiYamada4 mentioned this pull request Aug 30, 2024
Merged
4 tasks
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review August 30, 2024 02:35
@SakodaShintaro SakodaShintaro added the tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci) label Aug 30, 2024
SakodaShintaro
SakodaShintaro approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I ran the Evaluator tests (TIER IV INTERNAL LINK), and all the tests passed.
LGTM

@TaikiYamada4 TaikiYamada4 merged commit ba6f689 into autowarefoundation:main Aug 30, 2024
35 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/localization/stop_filter/export_param_file_to_launch branch August 30, 2024 07:55
ktro2828 pushed a commit to ktro2828/autoware.universe that referenced this pull request Sep 18, 2024
@TaikiYamada4 @ktro2828
chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (…
81bfb68 
…autowarefoundation#8681)

Extract stop_filter.param.yaml to autoware_launch

Signed-off-by: TaikiYamada4 <[email protected]>
h-ohta pushed a commit to tier4/autoware.universe that referenced this pull request Oct 17, 2024
@TaikiYamada4 @h-ohta
chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (…
34848af 
…autowarefoundation#8681)

Extract stop_filter.param.yaml to autoware_launch

Signed-off-by: TaikiYamada4 <[email protected]>
@h-ohta h-ohta mentioned this pull request Oct 17, 2024
Merged
This was referenced Oct 21, 2024
Merged
Merged
h-ohta added a commit to tier4/autoware.universe that referenced this pull request Oct 23, 2024
@h-ohta @TaikiYamada4
chore(stop_filter): extract stop_filter.param.yaml to autoware_launch (…
bad0007 
…autowarefoundation#8681) (#1591)

Co-authored-by: TaikiYamada4 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SakodaShintaro SakodaShintaro SakodaShintaro approved these changes

@anhnv3991 anhnv3991 Awaiting requested review from anhnv3991 anhnv3991 is a code owner

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi KYabuuchi is a code owner

@Motsu-san Motsu-san Awaiting requested review from Motsu-san Motsu-san is a code owner

@RyuYamamoto RyuYamamoto Awaiting requested review from RyuYamamoto RyuYamamoto is a code owner

@YamatoAndo YamatoAndo Awaiting requested review from YamatoAndo YamatoAndo is a code owner

Assignees
No one assigned
Labels
component:launch Launch files, scripts and initialization tools. (auto-assigned) tag:run-build-and-test-differential Mark to enable build-and-test-differential workflow. (used-by-ci)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TaikiYamada4 @SakodaShintaro