Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(stop_filter): extract stop_filter.param.yaml to autoware_launch #1145

Conversation

TaikiYamada4
Copy link
Contributor

@TaikiYamada4 TaikiYamada4 commented Aug 30, 2024

Description

Enable to set the param_path of stop filter.param.yaml.
Especially expected to get from autoware_launch.

Related links

This PR has to work and be merged with autowarefoundation/autoware.universe#8681 together.

How was this PR tested?

  1. Checked that rosbag replay tutorial works.
  2. Checked that ros2 param dump /localization/pose_twist_fusion_filter/stop_filter return the following. When I changed vx_threshold to 1.1.
/localization/pose_twist_fusion_filter/stop_filter:
  ros__parameters:
    qos_overrides:
      /clock:
        subscription:
          depth: 1
          durability: volatile
          history: keep_last
          reliability: best_effort
      /parameter_events:
        publisher:
          depth: 1000
          durability: volatile
          history: keep_last
          reliability: reliable
    use_sim_time: true
    vx_threshold: 1.1
    wz_threshold: 0.02
  1. Confirmed that minimum twist.x of /localization/kinematic_state changes when I change the parameter in autoware_launch.

Effects on system behavior

stop_filter will get parameters from stop_filter.param.yaml in autoware_launch

Interface changes

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@TaikiYamada4 TaikiYamada4 changed the title Extract stop_filter.param.yaml to autoware_launch chore(stop_filter): extract stop_filter.param.yaml to autoware_launch Aug 30, 2024
@TaikiYamada4 TaikiYamada4 marked this pull request as ready for review August 30, 2024 02:35
@TaikiYamada4 TaikiYamada4 merged commit 6b8f16e into autowarefoundation:main Aug 30, 2024
16 of 17 checks passed
@TaikiYamada4 TaikiYamada4 deleted the chore/localization/stop_filter/export_param_file_to_launch branch August 30, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:localization Vehicle's position determination in its environment. (auto-assigned) tag:run-build-and-test-differential
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants