Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

revert: revert "build: add exec_depend on ros_environment" #143

Merged
merged 1 commit into from
Jan 23, 2023
Merged

revert: revert "build: add exec_depend on ros_environment" #143

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions autoware_cmake/package.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,6 @@

<buildtool_depend>ament_cmake_auto</buildtool_depend>

<exec_depend>ros_environment</exec_depend>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it's true that autoware_cmake depends on ros_environment, I guess we should write the dependency in some way.

Seeing the example of gtest_vendor in ament_cmake_gtest, is buildtool_export_depend the correct tag?
https://github.com/ament/ament_cmake/blob/c5489e8c22489625a804618a160649953d21dec8/ament_cmake_gtest/package.xml#L19
https://github.com/ament/ament_cmake/blob/c5489e8c22489625a804618a160649953d21dec8/ament_cmake_gtest/ament_cmake_gtest-extras.cmake#L41

Is that wrong, too?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, #144 did it. Thank you @jspricke!

Copy link
Contributor Author

@esteve esteve Jan 23, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kenji-miyake autoware_cmake does not depend on ros_environment, it depends on the ROS_DISTRO environment variable, but not that package. So unfortunately, #144 is still incorrect.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@esteve Thank you. Hmm, let me confirm a little more.

There are two facts:

  1. ros_environment provides the environment variables ROS_VERSION and ROS_DISTRO.
share/ros_environment/package.xml
4:  <description>The package provides the environment variables `ROS_VERSION` and `ROS_DISTRO`.</description>
  1. Several packages, which depend on ROS_VERSION (one of the ros_environment's env), depend on ros_environment.

https://github.com/tier4/osqp_vendor/blob/1ea3682dacc08bd05d301098b202e74bd6416251/package.xml#L19

What's the difference between those packages and autoware_cmake?


<test_depend>ament_lint_auto</test_depend>
<test_depend>autoware_lint_common</test_depend>

Expand Down