This repository has been archived by the owner on Jul 1, 2024. It is now read-only.
feat(lanelet2_extension): add crosswalk regulatory element #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 10.74% 10.37% -0.37%
==========================================
Files 34 35 +1
Lines 2523 2613 +90
Branches 1325 1366 +41
==========================================
Hits 271 271
- Misses 1807 1897 +90
Partials 445 445
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
Merged
10 tasks
mitsudome-r
reviewed
Jun 12, 2023
There was a problem hiding this comment.
Thanks for creating the PR.
Also, please update documentation for the new regulatory element. https://github.com/autowarefoundation/autoware_common/blob/main/tmp/lanelet2_extension/docs/lanelet2_format_extension.md
tmp/lanelet2_extension/include/lanelet2_extension/utility/query.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/crosswalk-reg-elem
branch
from
c572b73
to
5aadeb2
Compare
…ement Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/crosswalk-reg-elem
branch
from
0fac52f
to
f98b582
Compare
|
I added documentation in 7ca1cad. |
mitsudome-r
reviewed
Jun 13, 2023
mitsudome-r
reviewed
Jun 13, 2023
...lanelet2_extension/include/lanelet2_extension/regulatory_elements/autoware_traffic_light.hpp
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <[email protected]>
satoshi-ota
force-pushed
the
feat/crosswalk-reg-elem
branch
from
eeddbdc
to
ddcfe51
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add crosswalk regulatory element to lanelet extension library.
The format is here.
Related links
discussion: https://github.com/orgs/autowarefoundation/discussions/3036
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.