-
Notifications
You must be signed in to change notification settings - Fork 71
feat(lanelet2_extension): add crosswalk regulatory element #187
feat(lanelet2_extension): add crosswalk regulatory element #187
Conversation
Signed-off-by: satoshi-ota <[email protected]>
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #187 +/- ##
==========================================
- Coverage 10.74% 10.37% -0.37%
==========================================
Files 34 35 +1
Lines 2523 2613 +90
Branches 1325 1366 +41
==========================================
Hits 271 271
- Misses 1807 1897 +90
Partials 445 445
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for creating the PR.
Also, please update documentation for the new regulatory element. https://github.com/autowarefoundation/autoware_common/blob/main/tmp/lanelet2_extension/docs/lanelet2_format_extension.md
tmp/lanelet2_extension/include/lanelet2_extension/utility/query.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
tmp/lanelet2_extension/include/lanelet2_extension/regulatory_elements/crosswalk.hpp
Outdated
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <[email protected]>
c572b73
to
5aadeb2
Compare
…ement Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
0fac52f
to
f98b582
Compare
I added documentation in 7ca1cad. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
...lanelet2_extension/include/lanelet2_extension/regulatory_elements/autoware_traffic_light.hpp
Show resolved
Hide resolved
Signed-off-by: satoshi-ota <[email protected]>
eeddbdc
to
ddcfe51
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Add crosswalk regulatory element to lanelet extension library.
The format is here.
Related links
discussion: https://github.com/orgs/autowarefoundation/discussions/3036
Tests performed
Notes for reviewers
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.