-
Notifications
You must be signed in to change notification settings - Fork 639
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(crosswalk): support crosswalk regulatory element #3939
feat(crosswalk): support crosswalk regulatory element #3939
Conversation
803c3aa
to
3dfbc1c
Compare
It seems that the lanelet2_map_visualization node has not yet supported the crosswalk reguratory element. |
@satoshi-ota |
@tkimura4 hmm... The map seems to be little bit wierd...? The crosswalk separates two lanelet. I guess that there is a special lane for bicycle. |
add crosswalk areas marker in 4c3a75c. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
4c3a75c
to
8258213
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3939 +/- ##
==========================================
- Coverage 14.45% 14.44% -0.01%
==========================================
Files 1456 1456
Lines 102538 102611 +73
Branches 29652 29705 +53
==========================================
+ Hits 14819 14824 +5
- Misses 71568 71620 +52
- Partials 16151 16167 +16
*This pull request uses carry forward flags. Click here to find out more.
☔ View full report in Codecov by Sentry. |
…tion#3939) * feat(crosswalk): use regulatory element Signed-off-by: satoshi-ota <[email protected]> * feat(map_loader): show crosswalk areas Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
…tion#3939) * feat(crosswalk): use regulatory element Signed-off-by: satoshi-ota <[email protected]> * feat(map_loader): show crosswalk areas Signed-off-by: satoshi-ota <[email protected]> --------- Signed-off-by: satoshi-ota <[email protected]>
Description
Crosswalk module supports regulatory element.
See https://github.com/orgs/autowarefoundation/discussions/3036
Related links
⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_common#187
Tests performed
Notes for reviewers
Crosswalk module checks the existence of regulatory elements.
Interface changes
Nothing.
Effects on system behavior
Nothing.
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.