Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(crosswalk): support crosswalk regulatory element #3939

Merged

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Jun 12, 2023

Description

Crosswalk module supports regulatory element.

See https://github.com/orgs/autowarefoundation/discussions/3036

Related links

⬇️ This PR must be merged before this PR.
autowarefoundation/autoware_common#187

Tests performed

Notes for reviewers

Crosswalk module checks the existence of regulatory elements.

Interface changes

Nothing.

Effects on system behavior

Nothing.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@github-actions github-actions bot added the component:planning Route planning, decision-making, and navigation. (auto-assigned) label Jun 12, 2023
@satoshi-ota satoshi-ota changed the title feat(crosswalk): use regulatory element feat(crosswalk): support crosswalk regulatory element Jun 12, 2023
@satoshi-ota satoshi-ota marked this pull request as ready for review June 12, 2023 06:34
@tkimura4
Copy link
Contributor

It seems that the lanelet2_map_visualization node has not yet supported the crosswalk reguratory element.
Will you implement it in another PR?

@tkimura4
Copy link
Contributor

The crosswalk module works well for crosswalk regulatory elements.
image

@tkimura4
Copy link
Contributor

@satoshi-ota
In some cases, the shape of the crosswalk polygon seems to be strange. Could you check it?
image

@satoshi-ota
Copy link
Contributor Author

@tkimura4 hmm... The map seems to be little bit wierd...? The crosswalk separates two lanelet. I guess that there is a special lane for bicycle.

image

@github-actions github-actions bot added the component:map Map creation, storage, and loading. (auto-assigned) label Jun 12, 2023
@satoshi-ota
Copy link
Contributor Author

It seems that the lanelet2_map_visualization node has not yet supported the crosswalk reguratory element. Will you implement it in another PR?

add crosswalk areas marker in 4c3a75c.

image

Copy link
Contributor

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

kminoda
kminoda previously approved these changes Jun 13, 2023
@kminoda kminoda dismissed their stale review June 13, 2023 04:40

Review required

Copy link
Contributor

@kminoda kminoda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Jun 13, 2023

Codecov Report

Patch coverage: 7.82% and project coverage change: -0.01 ⚠️

Comparison is base (f09e575) 14.45% compared to head (8258213) 14.44%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3939      +/-   ##
==========================================
- Coverage   14.45%   14.44%   -0.01%     
==========================================
  Files        1456     1456              
  Lines      102538   102611      +73     
  Branches    29652    29705      +53     
==========================================
+ Hits        14819    14824       +5     
- Misses      71568    71620      +52     
- Partials    16151    16167      +16     
Flag Coverage Δ *Carryforward flag
differential 18.52% <7.82%> (?)
total 14.45% <ø> (+<0.01%) ⬆️ Carriedforward from f09e575

*This pull request uses carry forward flags. Click here to find out more.

Impacted Files Coverage Δ
...et2_map_loader/lanelet2_map_visualization_node.cpp 0.00% <0.00%> (ø)
...th_planner/scene_module/lane_change/base_class.hpp 10.52% <ø> (ø)
...ath_planner/scene_module/lane_change/interface.hpp 50.00% <ø> (ø)
...nner/utils/lane_change/lane_change_module_data.hpp 50.00% <ø> (ø)
...or_path_planner/src/behavior_path_planner_node.cpp 18.64% <ø> (ø)
...planner/src/scene_module/lane_change/interface.cpp 14.55% <ø> (ø)
...cene_module/start_planner/start_planner_module.cpp 5.72% <ø> (+0.02%) ⬆️
planning/behavior_path_planner/src/utils/utils.cpp 17.12% <ø> (+0.02%) ⬆️
...behavior_velocity_crosswalk_module/src/manager.hpp 100.00% <ø> (ø)
..._velocity_crosswalk_module/src/scene_crosswalk.cpp 0.00% <0.00%> (ø)
... and 3 more

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@satoshi-ota satoshi-ota merged commit e62422b into autowarefoundation:main Jun 13, 2023
@satoshi-ota satoshi-ota deleted the feat/crosswalk-reg-elem branch June 13, 2023 09:06
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Jul 19, 2023
…tion#3939)

* feat(crosswalk): use regulatory element

Signed-off-by: satoshi-ota <[email protected]>

* feat(map_loader): show crosswalk areas

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
takayuki5168 pushed a commit to tier4/autoware.universe that referenced this pull request Aug 9, 2023
…tion#3939)

* feat(crosswalk): use regulatory element

Signed-off-by: satoshi-ota <[email protected]>

* feat(map_loader): show crosswalk areas

Signed-off-by: satoshi-ota <[email protected]>

---------

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component:map Map creation, storage, and loading. (auto-assigned) component:planning Route planning, decision-making, and navigation. (auto-assigned)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants