Skip to content
This repository has been archived by the owner on Jul 1, 2024. It is now read-only.

feat(build)!: add forward declaration header #203

Merged

Conversation

soblin
Copy link
Contributor

@soblin soblin commented Aug 30, 2023

Description

Add forward declaration header just as lanelet2_core lanelet2_routing package.

Related links

Tests performed

build passes

Notes for reviewers

Interface changes

This PR adds forward declaration header

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Member

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soblin
Copy link
Contributor Author

soblin commented Aug 30, 2023

@mitsudome-r Can you run the build test workflows ?

@codecov
Copy link

codecov bot commented Aug 30, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.31% ⚠️

Comparison is base (58039c8) 10.30% compared to head (5465090) 10.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #203      +/-   ##
==========================================
- Coverage   10.30%   10.00%   -0.31%     
==========================================
  Files          36       36              
  Lines        2629     2629              
  Branches     1366     1366              
==========================================
- Hits          271      263       -8     
- Misses       1913     1925      +12     
+ Partials      445      441       -4     
Flag Coverage Δ *Carryforward flag
differential 8.23% <0.00%> (?)
total 10.04% <ø> (-0.26%) ⬇️ Carriedforward from 58039c8

*This pull request uses carry forward flags. Click here to find out more.

Files Changed Coverage Δ
...ion/regulatory_elements/autoware_traffic_light.hpp 50.00% <ø> (ø)
...n/include/lanelet2_extension/utility/utilities.hpp ∅ <ø> (∅)
tmp/lanelet2_extension/lib/message_conversion.cpp 39.75% <ø> (ø)
tmp/lanelet2_extension/lib/query.cpp 7.17% <ø> (ø)
tmp/lanelet2_extension/lib/route_checker.cpp 77.77% <ø> (ø)
tmp/lanelet2_extension/lib/utilities.cpp 7.69% <0.00%> (-0.31%) ⬇️
tmp/lanelet2_extension/lib/visualization.cpp 0.00% <ø> (ø)
...et2_extension/test/src/test_message_conversion.cpp 19.67% <ø> (ø)
tmp/lanelet2_extension/test/src/test_query.cpp 19.29% <ø> (ø)
...lanelet2_extension/test/src/test_route_checker.cpp 37.93% <ø> (ø)
... and 1 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mitsudome-r mitsudome-r merged commit 8f23196 into autowarefoundation:main Aug 30, 2023
15 of 17 checks passed
@soblin soblin deleted the build-fast/lanelet2_extension branch September 14, 2023 08:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants