feat(vehicle_cmd_gate): change param to relax pedal rate limit when the vehicle velocity is slow enough #1077
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuki-takagi-66
requested review from
takayuki5168,
rej55,
satoshi-ota and
shmpwk
as code owners
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/relaxate-pedal-rate-limit-for-low-speed
branch
from
75ad2f7
to
2df8a0a
Compare
yuki-takagi-66
requested review from
ito-san,
isamu-takagi and
tkimura4
as code owners
github-actions
bot
added
component:system
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/relaxate-pedal-rate-limit-for-low-speed
branch
from
2df8a0a
to
4c57618
Compare
github-actions
bot
removed
component:system
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/relaxate-pedal-rate-limit-for-low-speed
branch
from
4c57618
to
62f3adb
Compare
github-actions
bot
added
component:system
Signed-off-by: Yuki Takagi <[email protected]>
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
force-pushed
the
vehicle_cmd_gate/relaxate-pedal-rate-limit-for-low-speed
branch
from
62f3adb
to
18f62bf
Compare
github-actions
bot
removed
component:system
Signed-off-by: Yuki Takagi <[email protected]>
yuki-takagi-66
requested review from
danielsanchezaran,
kyoichi-sugahara,
zulfaqar-azmi-t4,
go-sakayori and
kosuke55
as code owners
yuki-takagi-66
requested review from
mkquda,
maxime-clem,
soblin and
yhisaki
as code owners
|
@TakaHoribe |
takayuki5168
approved these changes
Jul 22, 2024
yuki-takagi-66
deleted the
vehicle_cmd_gate/relaxate-pedal-rate-limit-for-low-speed
branch
yuki-takagi-66
added a commit
to tier4/autoware_launch
that referenced
this pull request
Jul 22, 2024
…he vehicle velocity is slow enough (autowarefoundation#1077) * change param Signed-off-by: Yuki Takagi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR relax the pedal rate limit value when the vehicle velocity is slow enough to achieve stop/go on the slopes.
universe PR: autowarefoundation/autoware.universe#7720
Tests performed
I have tested this change by two type of real vehicles.
Effects on system behavior
Not applicable.
Interface changes
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.