feat: add arguments for pointcloud container to planning #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
yukkysaito
previously approved these changes
Apr 26, 2022
|
Thanks for the review. 🙏 |
|
@yukkysaito |
TomohitoAndo
force-pushed
the
feature/dynamic_obstacle_stop
branch
from
4c3fa54
to
79f24ba
Compare
Signed-off-by: Tomohito Ando <[email protected]>
Signed-off-by: Tomohito Ando <[email protected]>
TomohitoAndo
force-pushed
the
feature/dynamic_obstacle_stop
branch
from
79f24ba
to
d771acf
Compare
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Tomohito Ando [email protected]
Description
add arguments for pointcloud container to planning.launch.xml to run compare map filter in container.
https://github.com/TomohitoAndo/autoware.universe/blob/feature/dynamic_obstacle_stop/launch/tier4_planning_launch/launch/scenario_planning/lane_driving.launch.xml#L21-L26
Related links
autowarefoundation/autoware.universe#752
Tests performed
I confirmed
voxel_based_compare_map_filter_nodewas inpointcloud_constainerwhen the argument is true.Notes for reviewers
This PR should be merged with this PR.
autowarefoundation/autoware.universe#752
Pre-review checklist for the PR author
The PR author must check the checkboxes below when creating the PR.
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.