Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autoware_launch): add missing pose_initializer param #430

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jul 3, 2023

Description

Fix a bug in pose_initializer parameter file

Related links

N/A

Tests performed

Launched with map4_localization_component.launch.xml and confirmed that it launches without failure

Notes for reviewers

N/A

Interface changes

N/A

Effects on system behavior

N/A

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda requested a review from KYabuuchi July 3, 2023 08:24
Copy link
Contributor

@KYabuuchi KYabuuchi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. LGTM 👍

@kminoda kminoda merged commit 3dc306e into autowarefoundation:main Jul 3, 2023
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
maxime-clem pushed a commit to maxime-clem/autoware_launch that referenced this pull request Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants