Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(autoware_launch): update pointpainting param #473

Merged
merged 1 commit into from
Jul 24, 2023

Conversation

yukke42
Copy link
Contributor

@yukke42 yukke42 commented Jul 24, 2023

Description

This PR shuold be merged after autowarefoundation/autoware.universe#4314.

update pointpainting params from autowarefoundation/autoware.universe#4314 following #450

Related links

Tests performed

Notes for reviewers

Interface changes

Effects on system behavior

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR follows the pull request guidelines.
  • The PR has been properly tested.
  • The PR has been reviewed by the code owners.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukke42 yukke42 merged commit 5b820f7 into main Jul 24, 2023
13 of 14 checks passed
@yukke42 yukke42 deleted the feature/update-pointpainting-param branch July 24, 2023 13:28
soblin pushed a commit to soblin/autoware_launch that referenced this pull request Jul 25, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
kyoichi-sugahara pushed a commit that referenced this pull request Sep 3, 2023
mitukou1109 pushed a commit to mitukou1109/autoware_launch that referenced this pull request Jul 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants