Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change max_z of cropbox filter to vehicle_height #906

Conversation

badai-nguyen
Copy link
Contributor

Description

Tests performed

Not applicable.

Effects on system behavior

Not applicable.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

Copy link
Contributor

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@badai-nguyen badai-nguyen enabled auto-merge (squash) March 6, 2024 11:01
@badai-nguyen
Copy link
Contributor Author

@miursh @YoshiRi could please you approve this PR as your're codeowner 🙇

@badai-nguyen badai-nguyen merged commit 5180edd into autowarefoundation:main Mar 6, 2024
9 of 10 checks passed
@badai-nguyen badai-nguyen deleted the chore/ground_segmentation_param branch March 6, 2024 23:19
@badai-nguyen badai-nguyen restored the chore/ground_segmentation_param branch March 7, 2024 04:41
badai-nguyen added a commit to badai-nguyen/autoware_launch that referenced this pull request Apr 5, 2024
…dation#906)

chore: change max_z of cropbox filter to vehicle_heigh

Signed-off-by: badai-nguyen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants