Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: always separate lidar preprocessing from pointcloud_container #85

Merged
merged 7 commits into from
Jan 19, 2024

Conversation

kminoda
Copy link
Contributor

@kminoda kminoda commented Jan 16, 2024

Description

See autowarefoundation/autoware.universe#6091

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@kminoda kminoda changed the title feat!: replace use_pointcloud_container feat: always separate lidar preprocessing from pointcloud_container Jan 16, 2024
Signed-off-by: kminoda <[email protected]>
@kminoda kminoda force-pushed the feat/replace_use_pointcloud_container branch from 16b8bed to eb50925 Compare January 16, 2024 13:33
@kminoda kminoda marked this pull request as ready for review January 16, 2024 13:58
Copy link
Contributor

@miursh miursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Signed-off-by: kminoda <[email protected]>
@kminoda kminoda merged commit a6a7063 into main Jan 19, 2024
9 of 10 checks passed
@kminoda kminoda deleted the feat/replace_use_pointcloud_container branch January 19, 2024 01:00
@yvzksgl
Copy link
Member

yvzksgl commented Jan 24, 2024

Hello, firstly thanks for your greate work. I'm wondering why did not you remove use_pointcloud_container from pointcloud_preprocessor parts. @kminoda

@kminoda
Copy link
Contributor Author

kminoda commented Jan 25, 2024

Thank you for your comment. The flag is currently necessary to control whether to attach concatenation node to /pointcloud_container or not.
BTW we are considering removing the flag: https://github.com/orgs/autowarefoundation/discussions/4112

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants