Add failing CSS part to HMR demo #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
commented
Feb 2, 2022
|
Ok, so I'll try to fix the problem with the CSS extractor/loader. But maybe it's not a bug within this project and I may not start the work right now. Maybe a few days I'll come back. |
|
😭 Sorry for the delay but I still don't have time to investigate this problem. I have a deadline today! But I promise this issue is on my TODO list for a long time |
|
No worries, same here, I haven't had time to test your examples PR either 😅 |
|
well, it works, but by a very unwanted patch. |
|
It's very hacky, and the example also need rewrite |
crimx
approved these changes
Mar 13, 2022
fregante
commented
Mar 13, 2022
fregante
commented
Mar 13, 2022
crimx
approved these changes
Mar 15, 2022
5 tasks
|
Tested, it works! Thank you for the help |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #29
It seems that the error manifests even with the basic CSS extraction configuration, but only in
servemode;webpack buildworks correctly.This might not be a bug of this plugin