Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable hot-module reload #3012

Closed
wants to merge 6 commits into from
Closed

Enable hot-module reload #3012

wants to merge 6 commits into from

Conversation

fregante
Copy link
Contributor

@fregante fregante commented Mar 23, 2022

This demo video shows HMR of both React modules and CSS files, in the editor and in the options page:

Screen.Recording.2.mov

Questions

Thoughts? Should I flesh this out and document the new development usage? (i.e. do not use together with web-ext’s autoreload)

Keep in mind that the 4/5s delay is unrelated to this change. Here I'm just avoiding the need to refresh the editor/options to see any changes, which should speed development up considerably already.

Next

  • Figure out the level support of content scripts
  • Ensure these changes don't spill into production
  • Test more
  • Update web-ext run-related docs

Wishlist

Related

@twschiller
Copy link
Contributor

Should I flesh this out and document the new development usage? (i.e. do not use together with web-ext’s autoreload)

I think this HMR would be very helpful for speeding up development. From a developer ergonomics perspective, I'd like to focus on error telemetry first. Then this would be a good one to enable after. I'm also working on selector specifications today to unblock that line or work

@fregante
Copy link
Contributor Author

fregante commented May 3, 2022

Closing until it becomes higher priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants