Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Resend Purchase Receipt" assumes sending the email was successful #8986

Closed
ashleyfae opened this issue Nov 10, 2021 · 0 comments · Fixed by #8989
Closed

"Resend Purchase Receipt" assumes sending the email was successful #8986

ashleyfae opened this issue Nov 10, 2021 · 0 comments · Fixed by #8989

Comments

@ashleyfae
Copy link
Contributor

Bug Report

Expected behavior

If I opt to re-send a customer's purchase receipt, and sending the email fails, I expect to see an error message.

Actual behavior

I see an admin notice that says it was successful.

Steps to reproduce the behavior

  1. Easiest thing to do is to manually edit EDD_Emails::send() so that it returns false.
  2. Click the link via admin payment page to resend a purchase receipt.
  3. Note success message.

Information (if a specific version is affected):

PHP Version:

EDD Version (or branch): 2.9.x

WordPress Version:

Any other relevant information:

The edd_email_purchase_receipt() function should return the result of EDD_Emails::send().
Then in edd_resend_purchase_receipt() we should be checking the result of that and changing the edd-message query arg accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants