Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add failure notice if purchase receipt could not be re-sent #8989

Merged
merged 2 commits into from
Nov 12, 2021
Merged

Add failure notice if purchase receipt could not be re-sent #8989

merged 2 commits into from
Nov 12, 2021

Conversation

robincornett
Copy link
Contributor

Fixes #8986

Proposed Changes:

  1. Updates the emails send method to document the return.
  2. Updates edd_email_purchase_receipt to use that boolean and also return it.
  3. If that returns false when resending the purchase receipt, generate a failure/error notice.

@robincornett robincornett linked an issue Nov 11, 2021 that may be closed by this pull request
"Resend Purchase Receipt" assumes sending the email was successful #8986
Closed
@ashleyfae ashleyfae merged commit aaf9eb7 into release/2.11.4 Nov 12, 2021
@ashleyfae ashleyfae deleted the issue/8986 branch November 12, 2021 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleyfae ashleyfae ashleyfae approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"Resend Purchase Receipt" assumes sending the email was successful
2 participants
@robincornett @ashleyfae