-
Notifications
You must be signed in to change notification settings - Fork 472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUGFIX: Get price ID of product with variable prices included in Bundle #8776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in Bundle.
robincornett
requested changes
Jul 28, 2021
sergeykomlev
commented
Jul 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great suggestion!
robincornett
approved these changes
Jul 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, @sergeykomlev!
Hi @ashleyfae, will this change will be applied in the next releases? |
cklosowski
approved these changes
Aug 30, 2021
cklosowski
added a commit
that referenced
this pull request
Aug 30, 2021
* Update PayPal inactive gateway line item (#8826) #8825 * Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 (#8831) * Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 * Removing extra indents in gateway exception throws #8830 * Remove ID from hidden input and move buy now button to tokenizer #8830 * Adding nonces back in for backcompat of recurring #8830 * Move missing fields to a 400 instead of 403 #8830 * Remove locale from PayPal SDK parameters (#8824) #8823 * Updating version bumps for 2.11.1 * BUGFIX: Get price ID of product with variable prices included in Bundle (#8776) * BUGFIX: Get price ID of product with variable prices included in Bundle For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in Bundle. * Update history-downloads.php * Version bumps * Version bumps and rebuild pot file * Changelog and readme updates * Update readme.txt Co-authored-by: Robin Cornett <[email protected]> Co-authored-by: Robin Cornett <[email protected]> Co-authored-by: Sergey Komlev <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in the Bundle.