Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX: Get price ID of product with variable prices included in Bundle #8776

Merged
merged 2 commits into from
Aug 30, 2021

Conversation

sergeykomlev
Copy link
Contributor

For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in the Bundle.

For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in Bundle.
templates/history-downloads.php Outdated Show resolved Hide resolved
Copy link
Contributor Author

@sergeykomlev sergeykomlev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great suggestion!

@ashleyfae ashleyfae changed the base branch from master to release/2.11 July 29, 2021 09:56
@ashleyfae ashleyfae self-requested a review July 29, 2021 09:56
Copy link
Contributor

@robincornett robincornett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @sergeykomlev!

@sergeykomlev
Copy link
Contributor Author

Hi @ashleyfae, will this change will be applied in the next releases?

@robincornett robincornett changed the base branch from release/2.11 to release/2.11.1 August 30, 2021 13:59
@cklosowski cklosowski merged commit 00302d8 into awesomemotive:release/2.11.1 Aug 30, 2021
cklosowski added a commit that referenced this pull request Aug 30, 2021
* Update PayPal inactive gateway line item (#8826)

#8825

* Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 (#8831)

* Move PayPal Commerce to use the new tokenizer instaed of nonces #8830

* Removing extra indents in gateway exception throws #8830

* Remove ID from hidden input and move buy now button to tokenizer #8830

* Adding nonces back in for backcompat of recurring #8830

* Move missing fields to a 400 instead of 403 #8830

* Remove locale from PayPal SDK parameters (#8824)

#8823

* Updating version bumps for 2.11.1

* BUGFIX: Get price ID of product with variable prices included in Bundle (#8776)

* BUGFIX: Get price ID of product with variable prices included in Bundle

For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in Bundle.

* Update history-downloads.php

* Version bumps

* Version bumps and rebuild pot file

* Changelog and readme updates

* Update readme.txt

Co-authored-by: Robin Cornett <[email protected]>

Co-authored-by: Robin Cornett <[email protected]>
Co-authored-by: Sergey Komlev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get correct price ID of product with variable prices included in Bundle
3 participants