Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 #8831

Merged
merged 5 commits into from
Aug 25, 2021
Merged

Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 #8831

merged 5 commits into from
Aug 25, 2021

Conversation

cklosowski
Copy link
Contributor

Fixes #8830

Proposed Changes:

  1. Removes the nonce inputs and validation
  2. Converts over to the EDD\Utils\Tokenizer class to do validation

@cklosowski cklosowski linked an issue Aug 25, 2021 that may be closed by this pull request
PayPal Commerce: Intermittent Nonce Validation issues. #8830
Closed
ashleyfae
ashleyfae approved these changes Aug 25, 2021
View reviewed changes
Copy link
Contributor

@ashleyfae ashleyfae left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't tested this but just noting that the general approach seems fine.

@cklosowski cklosowski linked an issue Aug 25, 2021 that may be closed by this pull request
Custom checkout button markup can cause a JS error when clicked. #8834
Closed
@cklosowski cklosowski merged commit e02ea0e into release/2.11.1 Aug 25, 2021
@cklosowski cklosowski deleted the issue/8830 branch August 25, 2021 21:03
cklosowski added a commit that referenced this pull request Aug 30, 2021
@cklosowski @robincornett @sergeykomlev
Release/2.11.1 (#8838)
2e55064 
* Update PayPal inactive gateway line item (#8826)

#8825

* Move PayPal Commerce to use the new tokenizer instaed of nonces #8830 (#8831)

* Move PayPal Commerce to use the new tokenizer instaed of nonces #8830

* Removing extra indents in gateway exception throws #8830

* Remove ID from hidden input and move buy now button to tokenizer #8830

* Adding nonces back in for backcompat of recurring #8830

* Move missing fields to a 400 instead of 403 #8830

* Remove locale from PayPal SDK parameters (#8824)

#8823

* Updating version bumps for 2.11.1

* BUGFIX: Get price ID of product with variable prices included in Bundle (#8776)

* BUGFIX: Get price ID of product with variable prices included in Bundle

For product(s) with variable prices included in Bundle(s) we need to get price ID in a different way. Without this change, customers see all downloadable files for variable pricing products included in Bundle.

* Update history-downloads.php

* Version bumps

* Version bumps and rebuild pot file

* Changelog and readme updates

* Update readme.txt

Co-authored-by: Robin Cornett <[email protected]>

Co-authored-by: Robin Cornett <[email protected]>
Co-authored-by: Sergey Komlev <[email protected]>
@cklosowski cklosowski removed a link to an issue Aug 31, 2021
Custom checkout button markup can cause a JS error when clicked. #8834
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LisaCee LisaCee LisaCee approved these changes

@ashleyfae ashleyfae ashleyfae approved these changes

@robincornett robincornett robincornett approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PayPal Commerce: Intermittent Nonce Validation issues.
4 participants
@cklosowski @robincornett @ashleyfae @LisaCee