Skip to content

Commit

Permalink
Update code-style-lint.yml (#425)
Browse files Browse the repository at this point in the history
* Update code-style-lint.yml

only=dev is no longer supported and it is invalid config with npm i

* Replace AxiosRequestConfig with RawAxiosRequestConfig

In 1.2.3 AxiosRequestConfig interface has been refactored with RawAxiosRequestConfig. Committing package-lock.json for repeatable builds to prevent similar issues

Reference: https://github.com/axios/axios/releases/tag/v1.2.3

Co-authored-by: Garvit Singh <[email protected]>
  • Loading branch information
gsingh04 and gsingh04 authored Jan 18, 2023
1 parent e4689f5 commit 66fa67a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/code-style-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,5 +32,5 @@ jobs:
with:
node-version: ${{ matrix.node-version }}
- run: |
cd source && npm i --only=dev
cd source && npm i
npx --y eslint . --ext .ts
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -25,3 +25,4 @@ demo-ui-config.js
# System Files
**/.DS_Store
**/.vscode
**/.idea
6 changes: 3 additions & 3 deletions source/custom-resource/index.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import EC2, { DescribeRegionsRequest } from "aws-sdk/clients/ec2";
import S3, { CreateBucketRequest, PutBucketEncryptionRequest, PutBucketPolicyRequest } from "aws-sdk/clients/s3";
import SecretsManager from "aws-sdk/clients/secretsmanager";
import axios, { AxiosRequestConfig, AxiosResponse } from "axios";
import axios, { RawAxiosRequestConfig, AxiosResponse } from "axios";
import { createHash } from "crypto";
import moment from "moment";
import { v4 } from "uuid";
Expand Down Expand Up @@ -240,7 +240,7 @@ async function sendCloudFormationResponse(
Data: response.Data,
});

const config: AxiosRequestConfig = {
const config: RawAxiosRequestConfig = {
headers: {
"Content-Type": "",
"Content-Length": responseBody.length,
Expand Down Expand Up @@ -292,7 +292,7 @@ async function sendAnonymousMetric(

const payloadStr = JSON.stringify(payload);

const config: AxiosRequestConfig = {
const config: RawAxiosRequestConfig = {
headers: {
"content-type": "application/json",
"content-length": payloadStr.length,
Expand Down

0 comments on commit 66fa67a

Please sign in to comment.