Update code-style-lint.yml #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
only=dev is no longer supported and it is invalid config with npm i
G-Lenz
reviewed
Jan 17, 2023
| @@ -32,5 +32,5 @@ jobs: | |||
| with: | |||
| node-version: ${{ matrix.node-version }} | |||
| - run: | | |||
| cd source && npm i --only=dev | |||
| cd source && npm i | |||
There was a problem hiding this comment.
should this be doing a dev install like the previous line? If so can you still do production=false?
There was a problem hiding this comment.
It seems reasonable to run the linter on all source and not just prod deployment files if we can
hearde
approved these changes
Jan 18, 2023
dougtoppin
approved these changes
Jan 18, 2023
In 1.2.3 AxiosRequestConfig interface has been refactored with RawAxiosRequestConfig. Committing package-lock.json for repeatable builds to prevent similar issues Reference: https://github.com/axios/axios/releases/tag/v1.2.3
gockle
approved these changes
Jan 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
only=dev is no longer supported and it is invalid config with npm i
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.