Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

resolve eslint and codeql issues #413

Merged
merged 1 commit into from
Dec 23, 2022
Merged

resolve eslint and codeql issues #413

merged 1 commit into from
Dec 23, 2022

Conversation

dougtoppin
Copy link
Contributor

Description of changes:

  • resolve eslint and style related issues listed by github workflows
  • do not attempt eslint on tests
  • resolve CodeQL issue with regex in thumbor mapper

Checklist

  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@dougtoppin dougtoppin requested a review from a team December 23, 2022 15:50
evanwieren
evanwieren approved these changes Dec 23, 2022
View reviewed changes
Copy link
Contributor

@evanwieren evanwieren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@schana schana self-requested a review December 23, 2022 16:16
@evanwieren
Copy link
Contributor

Can we squash this.

schana
schana suggested changes Dec 23, 2022
View reviewed changes
Copy link
Member

@schana schana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we reduce the number of commits?

@dougtoppin dougtoppin merged commit d0ead90 into aws-solutions:develop Dec 23, 2022
@dougtoppin dougtoppin mentioned this pull request Jan 25, 2023
Merged
3 tasks
@dougtoppin dougtoppin deleted the feature/eslint branch February 16, 2023 20:18
thisismana pushed a commit to thisismana/serverless-image-handler that referenced this pull request Oct 2, 2024
@Marcel2603
BUZZ-5367 adding cache control for errors (aws-solutions#413)
3b404fe 
* BUZZ-5367 adding cache control for errors

* BUZZ-5367 fix tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schana schana schana approved these changes

@evanwieren evanwieren evanwieren approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dougtoppin @evanwieren @schana