Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(release): 6.1.1 #434

Merged
merged 23 commits into from
Feb 1, 2023
Merged

chore(release): 6.1.1 #434

merged 23 commits into from
Feb 1, 2023

Conversation

dougtoppin
Copy link
Contributor

@dougtoppin dougtoppin commented Jan 25, 2023

Issue #, if available:

Description of changes:
PRs contained within this release:

Checklist

  • 👋 I have added unit tests for all code changes.
  • 👋 I have run the unit tests, and all unit tests have passed.
  • ⚠️ This pull request might incur a breaking change.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

gsingh04 and others added 23 commits December 9, 2022 11:57
Address eslint and codeql issues
chore(gitignore): Add package-lock to gitignore
* Update node version

* Update contributing for develop branch and PR steps

* Update CONTRIBUTING.md, PULL_REQUEST_TEMPLATE.md, Add package-lock to gitignore

Co-authored-by: Doug Toppin <[email protected]>
* Update code-style-lint.yml

only=dev is no longer supported and it is invalid config with npm i

* Replace AxiosRequestConfig with RawAxiosRequestConfig

In 1.2.3 AxiosRequestConfig interface has been refactored with RawAxiosRequestConfig. Committing package-lock.json for repeatable builds to prevent similar issues

Reference: https://github.com/axios/axios/releases/tag/v1.2.3

Co-authored-by: Garvit Singh <[email protected]>
* Add package dependency files and do not ignore

* Commit package-lock.json files

Co-authored-by: Doug Toppin <[email protected]>
Bumps [json5](https://github.com/json5/json5) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/json5/json5/releases)
- [Changelog](https://github.com/json5/json5/blob/main/CHANGELOG.md)
- [Commits](json5/json5@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: json5
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Correct release date
@dougtoppin dougtoppin marked this pull request as ready for review February 1, 2023 20:01
Copy link
Member

@gsingh04 gsingh04 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@@ -0,0 +1,78 @@
#!/bin/bash
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replace with a no-op file, pipeline currently only looks for the file

with:
node-version: ${{ matrix.node-version }}
- run: |
cd source/constructs && npm i --only=dev
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

--only=dev no longer valid config for npm i

@dougtoppin dougtoppin merged commit b2e0871 into main Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants