Skip to content

Commit

Permalink
Revert messaging and version bump (#2187)
Browse files Browse the repository at this point in the history
* Revert "Version bump for [email protected] (#2186)"

This reverts commit 1f987a9.

* Revert "MessagingSession reconnects with refreshed endpoint and credentials if needed (#2180)"

This reverts commit e47bbbd.

* Remove demo/browser messaging client sdk dependency
  • Loading branch information
devalevenkatesh authored Apr 27, 2022
1 parent 1f987a9 commit 0f4ee96
Show file tree
Hide file tree
Showing 12 changed files with 4,441 additions and 8,828 deletions.
11 changes: 0 additions & 11 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,6 @@ All notable changes to this project will be documented in this file.
The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/),
and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).

## [3.2.0] - 2022-04-26

### Added

### Removed

### Changed

### Fixed

## [3.1.0] - 2022-04-07

### Added
Expand All @@ -33,7 +23,6 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- `MessagingSession` reconnects with refreshed endpoint and credentials if needed. EndpointUrl on `MessagingSessionConfiguration` is deprecated as it is resolved by calling `getMessagingSessionEndpoint` internally.
- Fix a bug that `remote-inbound-rtp` `RTCStatsReport` and `remote-outbound-rtp` `RTCStatsReport` of "video" `kind` are accidentally filtered.
- Fix the incorrect calculation of aggregation WebRTC metric spec (`audioSpeakerDelayMs`, `decoderLoss`).

Expand Down
5 changes: 3 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -230,7 +230,7 @@ The value of the MediaRegion parameter in the createMeeting() should ideally be
Create a messaging session in your client application to receive messages from Amazon Chime SDK for Messaging.

```js
import { ChimeSDKMessagingClient } from '@aws-sdk/client-chime-sdk-messaging';
import { ChimeSDKMessagingClient, GetMessagingSessionEndpointCommand } from '@aws-sdk/client-chime-sdk-messaging';

import {
ConsoleLogger,
Expand All @@ -243,10 +243,11 @@ const logger = new ConsoleLogger('SDK', LogLevel.INFO);

// You will need AWS credentials configured before calling AWS or Amazon Chime APIs.
const chime = new ChimeSDKMessagingClient({ region: 'us-east-1'});
const endpoint = await chime.send(new GetMessagingSessionEndpointCommand());

const userArn = /* The userArn */;
const sessionId = /* The sessionId */;
const configuration = new MessagingSessionConfiguration(userArn, sessionId, undefined, chime);
const configuration = new MessagingSessionConfiguration(userArn, sessionId, endpoint.Endpoint.Url, chime);
const messagingSession = new DefaultMessagingSession(configuration, logger);
```

Expand Down
5 changes: 3 additions & 2 deletions demos/browser/app/messagingSession/messagingSession.ts
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import {
Versioning,
} from 'amazon-chime-sdk-js';

import { ChimeSDKMessagingClient } from '@aws-sdk/client-chime-sdk-messaging';
import { ChimeSDKMessagingClient, GetMessagingSessionEndpointCommand } from '@aws-sdk/client-chime-sdk-messaging';

export class DemoMessagingSessionApp implements MessagingSessionObserver {
static readonly BASE_URL: string = [
Expand Down Expand Up @@ -54,9 +54,10 @@ export class DemoMessagingSessionApp implements MessagingSessionObserver {
try {
const response = await this.fetchCredentials();
const chime = new ChimeSDKMessagingClient({ region: 'us-east-1', credentials: response });
const endpoint = await chime.send(new GetMessagingSessionEndpointCommand());
this.userArn = (document.getElementById('userArn') as HTMLInputElement).value;
this.sessionId = (document.getElementById('sessionId') as HTMLInputElement).value;
this.configuration = new MessagingSessionConfiguration(this.userArn, this.sessionId, undefined, chime);
this.configuration = new MessagingSessionConfiguration(this.userArn, this.sessionId, endpoint.Endpoint.Url, chime);
this.session = new DefaultMessagingSession(this.configuration, this.logger);
this.session.addObserver(this);
this.session.start();
Expand Down
Loading

0 comments on commit 0f4ee96

Please sign in to comment.