MessagingSession reconnects with refreshed endpoint and credentials if needed #2180
Conversation
CHANGELOG.md
Outdated
| ## [3.1.1] - 2022-04-07 | ||
|
|
||
| ### Added | ||
|
|
||
| ### Removed | ||
|
|
||
| ### Changed | ||
|
|
||
| ### Fixed | ||
|
|
||
| - MessagingSession reconnects with refreshed endpoint and credentials if needed | ||
|
|
There was a problem hiding this comment.
We haven't released 3.1.0 version. I think you should add your CHANGELOG under 3.1.0 section.
And remove 3.1.1 section.
There was a problem hiding this comment.
@dpwspoon Hi, when do we schedule this release? if it's before the release of 3.1.0. Maybe we should update the version to 3.0.1, if it's a patch version.
Sorry I didn't catch this in the previous comment.
There was a problem hiding this comment.
@ltrung @devalevenkatesh how do you think?
There was a problem hiding this comment.
So, this chanelog can be under 3.1.0 we will later fix the changelog once the patch is released. I think I had checked the same with Trung. After release we will need to add 3.0.1 as a patch with this change.
There was a problem hiding this comment.
The changelog update is a bit of improvement we have to make once we go through this hotfix release once and fix any hiccups if seen. But yes, we would like to add as part of the PR after we release this time.
* Revert "Version bump for [email protected] (#2186)" This reverts commit 1f987a9. * Revert "MessagingSession reconnects with refreshed endpoint and credentials if needed (#2180)" This reverts commit e47bbbd. * Remove demo/browser messaging client sdk dependency
MessagingSession reconnects with refreshed endpoint and credentials if needed
Issue #:
Description of changes:
MessagingSession reconnects with refreshed endpoint and credentials if needed
Testing:
Tested on 2.x line with chime demo and this is cherry pick of that but will try testing using https://github.com/aws/amazon-chime-sdk-js/blob/main/demos/browser/app/messagingSession/messagingSession.ts
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
Start the messaging demo. Force the network to shutdown and then reopen. Should reconnect.
Checklist:
Have you successfully run
npm run build:releaselocally?yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
~ sort of. I made a parameter optional
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.