-
Notifications
You must be signed in to change notification settings - Fork 477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Messaging session bug fix #2431
Conversation
…2429) This change is to follow the protobuf changes in backend including 1. Add metric type of whether encoder/decoder implementation name is in hardware. 2. Add a dimension field for stream metric frame. 3. Rename VIDEO_AVERAGE_ENCODE_MS to VIDEO_ENCODE_MS to make it consistent with VIDEO_DECODE_MS.
Report encode/decode time and if encoder/decoder is in hardware, and add encoder/decoder name as a metric dimension Co-authored-by: Shi Su <[email protected]>
Co-authored-by: Venkatesh Devale <[email protected]>
Fix a confusing function name from millisecondsPerSecond to averageTimeSpentPerSecondInMillisecond.
…ckwards compatibility with AWS JS SDK V2 for getMessagingSessionEndpoint
@@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0 | |||
|
|||
### Fixed | |||
|
|||
- `MessagingSession` reconnect loop did not break on error past reconnect deadline. Infinite reconnect loop was caused due to firstConnectionAttemptTimestamp not being set as startedConnectionAttempt was not invoked. Check https://github.com/aws/amazon-chime-sdk-js/issues/2372 for details. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Back tick firstConnectionAttemptTimestamp
and startedConnectionAttempt
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the package-lock.json
changes necessary?
Does not look like from the fix that those are needed.
The base branch was changed.
Closing due to #2444 |
Issue #:
#2372
Description of changes:
Testing:
Tested reconnect loop fix by expiring credentials to validate reconnect loop on messagingSession breaks after the timeout
Tested compatibility with aws sdk v2 by changing the chime client instantiation in the messagingSession demo
Set aws credentials with in correct aws session token
Run the messagingSession demo here: https://github.com/aws/amazon-chime-sdk-js/tree/main/demos/browser. npm run start --app=messagingSession
connect with an app instance user
Reconnect loop is triggered but breaks after timeout
Can these tested using a demo application? Please provide reproducible step-by-step instructions.
To Test aws js sdk v2 compatibility run the messagingSession demo with below changes
Make the following changes in amazon-chime-sdk-js/demos/browser/app/messagingSession/messagingSession.ts
and change
To Test aws js sdk v3 with v2 style run the messagingSession demo with below changes
Make the following changes in amazon-chime-sdk-js/demos/browser/app/messagingSession/messagingSession.ts
and
and then run
Checklist:
Have you successfully run
npm run build:release
locally?yes
Do you add, modify, or delete public API definitions? If yes, has that been reviewed and approved?
no
Do you change the wire protocol, e.g. the request method? If yes, has that been reviewed and approved?
no
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
yes