Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Messaging session bug fix #2431

Closed
wants to merge 10 commits into from
Closed

Messaging session bug fix #2431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
ad05d77
Bug Fix: messagionSession reconnect loop now breaks on timeout
manasisurve Sep 9, 2022
4f86f7e
Add backwards compatibility with aws sdk v2 for getMessagingSessionEn…
manasisurve Sep 12, 2022
19e0a1e
Add encoder/decoder is hardware metric and stream metric dimension (#…
shi-su Sep 9, 2022
45cc844
Add backwards compatibility with aws sdk v2 for getMessagingSessionEn…
manasisurve Sep 12, 2022
ae297c9
Merge branch 'main' into messaging-session-bug-fix
manasisurve Sep 15, 2022
33b8fa3
Report encode/decode time and implementation metric (#2434)
shi-su Sep 16, 2022
ddcd9ae
Add live connector feature button to demo app (#2440)
yuqil-amzn Sep 16, 2022
d380975
Rename a function with a confusing name (#2443)
shi-su Sep 17, 2022
d7fb117
Fix messagingSession infinite reconnect loop on error and also add ba…
manasisurve Sep 19, 2022
ccebc74
Merge branch 'main' into messaging-session-bug-fix
manasisurve Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0

### Fixed

- `MessagingSession` reconnect loop did not break on error past reconnect deadline. Infinite reconnect loop was caused due to firstConnectionAttemptTimestamp not being set as startedConnectionAttempt was not invoked. Check https://github.com/aws/amazon-chime-sdk-js/issues/2372 for details.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Back tick firstConnectionAttemptTimestamp and startedConnectionAttempt.

- `MessagingSession` `getMessagingSessionEndpoint` call is now backwards compatible with AWS JS SDK v2.
- Use a default "playback" `latencyHint` when creating the `AudioContext` on Windows. Also adds a `setDefaultLatencyHint` API to `DefaultDeviceController` to allow for overriding.

## [3.7.0] - 2022-07-05
Expand Down
Loading