place binaries in cmd/ and packages in pkg/ #815
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use Golang idiomatic best practices for placement of binaries (into cmd/ directory) and packages (in pkg/ directory). * Move client/health-check/grpc_health_probe.go to cmd/grpc-health-probe/main.go * Move ipamd/* into pkg/ipamd * Move cni-metrics-helper/cni-metrics-helper.go to cmd/cni-metrics-helper/main.go and driver/ package under cmd/cni-metrics-helper/driver * Move plugins/routed-eni to cmd/routed-eni-cni-plugin * Move main.go to cmd/aws-k8s-agent/main.go * Update v1.5 config's aws-vpc-cni.yaml and scripts/entrypoint.sh to reflect new grpc-health-probe binary name * Update Dockerfiles with new binary names Closes Issue aws#746
mogren
approved these changes
Jan 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use Golang idiomatic best practices for placement of binaries (into cmd/
directory) and packages (in pkg/ directory).
cmd/grpc-health-probe/main.go
cmd/cni-metrics-helper/main.go and driver/ package under
cmd/cni-metrics-helper/driver
reflect new grpc-health-probe binary name
Closes Issue #746
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.