Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

place binaries in cmd/ and packages in pkg/ #815

Merged
merged 1 commit into from
Jan 29, 2020

Commits on Jan 29, 2020

  1. place binaries in cmd/ and packages in pkg/

    Use Golang idiomatic best practices for placement of binaries (into cmd/
    directory) and packages (in pkg/ directory).
    
    * Move client/health-check/grpc_health_probe.go to
      cmd/grpc-health-probe/main.go
    * Move ipamd/* into pkg/ipamd
    * Move cni-metrics-helper/cni-metrics-helper.go to
      cmd/cni-metrics-helper/main.go and driver/ package under
      cmd/cni-metrics-helper/driver
    * Move plugins/routed-eni to cmd/routed-eni-cni-plugin
    * Move main.go to cmd/aws-k8s-agent/main.go
    * Update v1.5 config's aws-vpc-cni.yaml and scripts/entrypoint.sh to
      reflect new grpc-health-probe binary name
    * Update Dockerfiles with new binary names
    
    Closes Issue aws#746
    jaypipes committed Jan 29, 2020
    Configuration menu
    Copy the full SHA
    dcff38e View commit details
    Browse the repository at this point in the history