Skip to content

Commit

Permalink
fix(eks): incorrect version of aws-node-termination-handler (#19510)
Browse files Browse the repository at this point in the history
A previous [PR](#18841) upgraded the version of `aws-node-termination-handler`. However, the version contained in the change, 1.14.0, refers to the `appVersion` field and not the `version` field. This change upgrades it to the latest available `version`, 0.18.0, as shown by the command:

```
$ helm search repo aws-node-termination-handler
NAME                            	CHART VERSION	APP VERSION	DESCRIPTION
eks/aws-node-termination-handler	0.18.0       	1.16.0     	A Helm chart for the AWS Node Termination Handler.
```

----

### All Submissions:

* [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md)

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
  • Loading branch information
otaviomacedo authored Mar 31, 2022
1 parent fd1fff9 commit 9c712cc
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion packages/@aws-cdk/aws-eks/lib/cluster.ts
Original file line number Diff line number Diff line change
Expand Up @@ -946,7 +946,7 @@ abstract class ClusterBase extends Resource implements ICluster {
if (!this._spotInterruptHandler) {
this._spotInterruptHandler = this.addHelmChart('spot-interrupt-handler', {
chart: 'aws-node-termination-handler',
version: '1.14.1',
version: '0.18.0',
repository: 'https://aws.github.io/eks-charts',
namespace: 'kube-system',
values: {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2690,7 +2690,7 @@
},
"Release": "ksclustertestclusterchartspotinterrupthandlerf41ba997",
"Chart": "aws-node-termination-handler",
"Version": "1.14.1",
"Version": "0.18.0",
"Values": "{\"nodeSelector\":{\"lifecycle\":\"Ec2Spot\"}}",
"Namespace": "kube-system",
"Repository": "https://aws.github.io/eks-charts",
Expand Down

0 comments on commit 9c712cc

Please sign in to comment.