-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eks): incorrect version of aws-node-termination-handler #19510
Conversation
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Thank you for contributing! Your pull request will be updated from master and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
@otaviomacedo Sorry about this. |
A previous [PR](aws#18841) upgraded the version of `aws-node-termination-handler`. However, the version contained in the change, 1.14.0, refers to the `appVersion` field and not the `version` field. This change upgrades it to the latest available `version`, 0.18.0, as shown by the command: ``` $ helm search repo aws-node-termination-handler NAME CHART VERSION APP VERSION DESCRIPTION eks/aws-node-termination-handler 0.18.0 1.16.0 A Helm chart for the AWS Node Termination Handler. ``` ---- ### All Submissions: * [x] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/master/CONTRIBUTING.md) *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
A previous PR upgraded the version of
aws-node-termination-handler
. However, the version contained in the change, 1.14.0, refers to theappVersion
field and not theversion
field. This change upgrades it to the latest availableversion
, 0.18.0, as shown by the command:All Submissions:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license