fix(route53-targets): InterfaceVpcEndpointTarget incorrectly accepts an imported endpoint #21523
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
InterfaceVpcEndpoint The `InterfaceVpcEndpointTarget` currently accepts an imported endpoint `IInterfaceVpcEndpoint`, but the actual implementation requires access to the `CfnVPCEndpoint` resource which is only available from the `InterfaceVpcEndpoint`. This appears as breaking, but I don't think it should be considered as breaking since you can currently _only_ pass a `InterfaceVpcEndpoint`. I thought about adding support for `IInterfaceVpcEndpoint`, but that would require updating the `fromxxx` method to take the route53 zone and the DNS name for the endpoint. If you need to know those values to use this construct then you might as well just create a normal Route53 record. closes #10432
|
|
github-actions
bot
added
bug
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
corymhall
changed the title
TheRealAmazonKendra
added
the
pr-linter/exempt-test
TheRealAmazonKendra
approved these changes
Aug 9, 2022
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
josephedward
pushed a commit
to josephedward/aws-cdk
that referenced
this pull request
Aug 30, 2022
…an imported endpoint (aws#21523) The `InterfaceVpcEndpointTarget` currently accepts an imported endpoint `IInterfaceVpcEndpoint`, but the actual implementation requires access to the `CfnVPCEndpoint` resource which is only available from the `InterfaceVpcEndpoint`. This appears as breaking, but I don't think it should be considered as breaking since you can currently _only_ pass a `InterfaceVpcEndpoint`. I thought about adding support for `IInterfaceVpcEndpoint`, but that would require updating the `fromxxx` method to take the route53 zone and the DNS name for the endpoint. If you need to know those values to use this construct then you might as well just create a normal Route53 record. closes aws#10432 ---- ### All Submissions: * [ ] Have you followed the guidelines in our [Contributing guide?](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) ### Adding new Unconventional Dependencies: * [ ] This PR adds new unconventional dependencies following the process described [here](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md/#adding-new-unconventional-dependencies) ### New Features * [ ] Have you added the new feature to an [integration test](https://github.com/aws/aws-cdk/blob/main/INTEGRATION_TESTS.md)? * [ ] Did you use `yarn integ` to deploy the infrastructure and generate the snapshot (i.e. `yarn integ` without `--dry-run`)? *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
InterfaceVpcEndpointTargetcurrently accepts an imported endpointIInterfaceVpcEndpoint, but the actual implementation requires accessto the
CfnVPCEndpointresource which is only available from theInterfaceVpcEndpoint.This appears as breaking, but I don't think it should be considered as
breaking since you can currently only pass a
InterfaceVpcEndpoint.I thought about adding support for
IInterfaceVpcEndpoint, but thatwould require updating the
fromxxxmethod to take the route53 zone andthe DNS name for the endpoint. If you need to know those values to use
this construct then you might as well just create a normal Route53
record.
closes #10432
All Submissions:
Adding new Unconventional Dependencies:
New Features
yarn integto deploy the infrastructure and generate the snapshot (i.e.yarn integwithout--dry-run)?By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license